Skip to content

Bugfix/end to end encryption - #10244

Merged
Rello merged 2 commits into
masterfrom
bugfix/endToEndEncryption
Jun 24, 2026
Merged

Bugfix/end to end encryption#10244
Rello merged 2 commits into
masterfrom
bugfix/endToEndEncryption

fix(encryption): prevent user to leave encrypted shares: not possible

8b9d44b
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed Jun 24, 2026 in 50m 48s

Quality Gate failed

Failed conditions
26.1% Coverage on New Code (required ≥ 80%)
D Security Rating on New Code (required ≥ A)
E Reliability Rating on New Code (required ≥ A)
E Maintainability Rating on New Code (required ≥ A)
238 New Code Smells (required ≤ 0)
1 New Bugs (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Annotations

Check failure on line 1703 in src/libsync/discovery.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Explicitly capture the required scope variables. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ752_gk6OA4qYu6YpfG&open=AZ752_gk6OA4qYu6YpfG&pullRequest=10244

Check failure on line 2472 in src/libsync/discovery.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add a "default" case to this switch statement. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ752_gk6OA4qYu6YpfX&open=AZ752_gk6OA4qYu6YpfX&pullRequest=10244

Check warning on line 181 in src/libsync/foldermetadata.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this identifier to be shorter or equal to 31 characters. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ752_i_6OA4qYu6YpgR&open=AZ752_i_6OA4qYu6YpgR&pullRequest=10244

Check warning on line 1749 in src/gui/folderman.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unmodified variable "status" of type "enum OCC::SyncResult::Status *" should be const-qualified. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ752_SC6OA4qYu6Ypdg&open=AZ752_SC6OA4qYu6Ypdg&pullRequest=10244

Check warning on line 57 in src/libsync/foldermetadata.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unmodified variable "account" of type "class QSharedPointer<class OCC::Account>" should be const-qualified. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ752_i26OA4qYu6Ypff&open=AZ752_i26OA4qYu6Ypff&pullRequest=10244

Check warning on line 116 in src/gui/folderman.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make the type of this parameter a pointer-to-const. The current type of "f" is "class OCC::Folder *". 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ752_SC6OA4qYu6YpdN&open=AZ752_SC6OA4qYu6YpdN&pullRequest=10244

Check failure on line 690 in src/gui/folderman.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this code to not nest more than 3 if|for|do|while|switch statements. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ752_SC6OA4qYu6YpdQ&open=AZ752_SC6OA4qYu6YpdQ&pullRequest=10244

Check warning on line 247 in src/libsync/foldermetadata.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Complete the task associated to this "TODO" comment. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ752_i26OA4qYu6Ypfe&open=AZ752_i26OA4qYu6Ypfe&pullRequest=10244

Check warning on line 1292 in src/gui/socketapi/socketapi.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace the redundant type with "auto". 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ752_NU6OA4qYu6YpdH&open=AZ752_NU6OA4qYu6YpdH&pullRequest=10244

Check warning on line 182 in src/libsync/foldermetadata.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this identifier to be shorter or equal to 31 characters. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ752_i_6OA4qYu6YpgS&open=AZ752_i_6OA4qYu6YpgS&pullRequest=10244

Check warning on line 705 in src/libsync/discoveryphase.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace with the version of "std::ranges::find_if" that takes a range. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ752_T06OA4qYu6YpeQ&open=AZ752_T06OA4qYu6YpeQ&pullRequest=10244

Check warning on line 428 in src/libsync/discovery.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Reduce this switch case number of lines from 6 to at most 5, for example by extracting code into methods. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ752_gk6OA4qYu6Ype1&open=AZ752_gk6OA4qYu6Ype1&pullRequest=10244

Check failure on line 104 in src/libsync/encryptedfoldermetadatahandler.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace the use of "new" with an operation that automatically manages the memory. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ752_cW6OA4qYu6YpeW&open=AZ752_cW6OA4qYu6YpeW&pullRequest=10244

Check warning on line 1496 in src/gui/folderman.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace with the version of "std::ranges::find_if" that takes a range. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ752_SC6OA4qYu6YpdY&open=AZ752_SC6OA4qYu6YpdY&pullRequest=10244

Check warning on line 1193 in src/gui/socketapi/socketapi.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This function should be declared "const". 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ752_NU6OA4qYu6YpdC&open=AZ752_NU6OA4qYu6YpdC&pullRequest=10244

Check warning on line 663 in src/libsync/discoveryphase.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Reduce this switch case number of lines from 8 to at most 5, for example by extracting code into methods. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ752_T06OA4qYu6YpeM&open=AZ752_T06OA4qYu6YpeM&pullRequest=10244

Check warning on line 386 in src/libsync/foldermetadata.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this identifier to be shorter or equal to 31 characters. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ752_i26OA4qYu6Ypfr&open=AZ752_i26OA4qYu6Ypfr&pullRequest=10244

Check warning on line 1054 in src/gui/folderman.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unmodified variable "f" of type "class OCC::Folder *" should be const-qualified. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ752_SC6OA4qYu6YpdU&open=AZ752_SC6OA4qYu6YpdU&pullRequest=10244

Check warning on line 2128 in src/libsync/discovery.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace with the version of "std::ranges::find_if" that takes a range. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ752_gk6OA4qYu6YpfM&open=AZ752_gk6OA4qYu6YpfM&pullRequest=10244

Check warning on line 2493 in src/libsync/discovery.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

implicit conversion loses integer precision: 'qsizetype' (aka 'long long') to 'int' 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ752_gk6OA4qYu6Ypel&open=AZ752_gk6OA4qYu6Ypel&pullRequest=10244

Check warning on line 643 in src/libsync/foldermetadata.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unmodified variable "end" of type "class QSet<class QByteArray>::const_iterator" should be const-qualified. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ752_i26OA4qYu6Ypf0&open=AZ752_i26OA4qYu6Ypf0&pullRequest=10244

Check warning on line 1169 in src/gui/socketapi/socketapi.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use the init-statement to declare "theme" inside the if statement. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ752_NU6OA4qYu6YpdA&open=AZ752_NU6OA4qYu6YpdA&pullRequest=10244

Check warning on line 1872 in src/libsync/discovery.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove these redundant parentheses. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ752_gk6OA4qYu6YpfK&open=AZ752_gk6OA4qYu6YpfK&pullRequest=10244

Check warning on line 2490 in src/libsync/discovery.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Reduce this switch case number of lines from 14 to at most 5, for example by extracting code into methods. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ752_gk6OA4qYu6YpfW&open=AZ752_gk6OA4qYu6YpfW&pullRequest=10244

Check warning on line 1659 in src/libsync/discovery.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this declaration by a structured binding declaration. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ752_gk6OA4qYu6YpfF&open=AZ752_gk6OA4qYu6YpfF&pullRequest=10244
View more details on SonarQubeCloud