Skip to content

Feature/governance labels integration - #10100

Merged
mgallien merged 26 commits into
masterfrom
feature/governanceLabelsIntegration
Jul 13, 2026
Merged

Feature/governance labels integration#10100
mgallien merged 26 commits into
masterfrom
feature/governanceLabelsIntegration

feat(governance): deduplicate some code

7c72a6d
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed Jul 13, 2026 in 43m 42s

Quality Gate failed

Failed conditions
56.8% Coverage on New Code (required ≥ 80%)
D Security Rating on New Code (required ≥ A)
170 New Code Smells (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Annotations

Check warning on line 794 in src/gui/owncloudgui.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unmodified variable "account" of type "class QSharedPointer<class OCC::Account>" should be const-qualified. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ9MigpnjuOfYSgZmLhw&open=AZ9MigpnjuOfYSgZmLhw&pullRequest=10100

Check warning on line 4 in src/gui/governance/deletegovernancelabel.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Edit this comment to use the C++ format, i.e. "//". 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ9Migm8juOfYSgZmLhR&open=AZ9Migm8juOfYSgZmLhR&pullRequest=10100

Check warning on line 270 in src/gui/owncloudgui.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This function should be declared "const". 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ9MigpnjuOfYSgZmLht&open=AZ9MigpnjuOfYSgZmLht&pullRequest=10100

Check failure on line 189 in src/gui/governance/governancelabelslistmodel.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add a "default" case to this switch statement. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ9Migl-juOfYSgZmLgp&open=AZ9Migl-juOfYSgZmLgp&pullRequest=10100

Check warning on line 421 in src/gui/socketapi/socketapi.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Avoid this unnecessary copy by using a "const" reference. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ9MiguEjuOfYSgZmLh4&open=AZ9MiguEjuOfYSgZmLh4&pullRequest=10100

Check warning on line 351 in src/gui/governance/governancelabelslistmodel.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unmodified variable "newLabelBehavior" of type "enum OCC::GovernanceLabelsListModel::LabelBehavior" should be const-qualified. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ9Migl-juOfYSgZmLgx&open=AZ9Migl-juOfYSgZmLgx&pullRequest=10100

Check warning on line 1302 in src/gui/socketapi/socketapi.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make the type of this parameter a pointer-to-const. The current type of "listener" is "class OCC::SocketListener *". 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ9MiguEjuOfYSgZmLiV&open=AZ9MiguEjuOfYSgZmLiV&pullRequest=10100

Check warning on line 318 in src/gui/governance/governancelabelslistmodel.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Declaration shadows a local variable "oneLabelObject" in the outer scope. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ9Migl-juOfYSgZmLgs&open=AZ9Migl-juOfYSgZmLgs&pullRequest=10100

Check warning on line 814 in src/gui/application.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This function should be declared "const". 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ9MigwVjuOfYSgZmLim&open=AZ9MigwVjuOfYSgZmLim&pullRequest=10100

Check warning on line 1023 in src/gui/socketapi/socketapi.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Avoid this unnecessary copy by using a "const" reference. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ9MiguEjuOfYSgZmLiI&open=AZ9MiguEjuOfYSgZmLiI&pullRequest=10100

Check warning on line 28 in src/gui/governance/getavailablegovernancelabels.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this access specifier; it does not affect any declaration. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ9MiglejuOfYSgZmLgY&open=AZ9MiglejuOfYSgZmLgY&pullRequest=10100

Check warning on line 1074 in src/gui/socketapi/socketapi.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use the init-statement to declare "parentRecord" inside the if statement. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ9MiguEjuOfYSgZmLiK&open=AZ9MiguEjuOfYSgZmLiK&pullRequest=10100

Check warning on line 164 in src/gui/governance/governancenetworkjob.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unmodified variable "newAccount" of type "class QSharedPointer<class OCC::Account>" should be const-qualified. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ9Migm0juOfYSgZmLhN&open=AZ9Migm0juOfYSgZmLhN&pullRequest=10100

Check failure on line 176 in src/gui/governance/governancenetworkjob.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Add a nested comment explaining why this method is empty, or complete the implementation. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ9Migm0juOfYSgZmLhO&open=AZ9Migm0juOfYSgZmLhO&pullRequest=10100

Check warning on line 735 in src/gui/application.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This function should be declared "const". 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ9MigwVjuOfYSgZmLij&open=AZ9MigwVjuOfYSgZmLij&pullRequest=10100

Check warning on line 108 in src/gui/systray.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this identifier to be shorter or equal to 31 characters. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ9MigxJjuOfYSgZmLiv&open=AZ9MigxJjuOfYSgZmLiv&pullRequest=10100

Check warning on line 762 in src/gui/socketapi/socketapi.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unmodified variable "url" of type "class QUrl" should be const-qualified. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ9MiguEjuOfYSgZmLh_&open=AZ9MiguEjuOfYSgZmLh_&pullRequest=10100

Check warning on line 4 in src/gui/governance/governancelabelinfo.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Edit this comment to use the C++ format, i.e. "//". 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ9Migl1juOfYSgZmLgc&open=AZ9Migl1juOfYSgZmLgc&pullRequest=10100

Check warning on line 174 in src/gui/socketapi/socketapi.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this identifier to be shorter or equal to 31 characters. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ9MigqSjuOfYSgZmLhy&open=AZ9MigqSjuOfYSgZmLhy&pullRequest=10100

Check warning on line 319 in src/gui/governance/governancelabelslistmodel.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

implicit conversion loses integer precision: 'const qsizetype' (aka 'const long long') to 'int' 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ9Migl-juOfYSgZmLgh&open=AZ9Migl-juOfYSgZmLgh&pullRequest=10100

Check warning on line 319 in src/gui/systray.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unmodified variable "userIndex" of type "int" should be const-qualified. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ9MigojjuOfYSgZmLhd&open=AZ9MigojjuOfYSgZmLhd&pullRequest=10100

Check warning on line 53 in src/libsync/accessmanager.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the redundant return type of this lambda. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ9MigxkjuOfYSgZmLi2&open=AZ9MigxkjuOfYSgZmLi2&pullRequest=10100

Check warning on line 56 in src/gui/governance/typedgovernancenetworkjob.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Reduce this switch case number of lines from 16 to at most 5, for example by extracting code into methods. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ9MigmVjuOfYSgZmLg5&open=AZ9MigmVjuOfYSgZmLg5&pullRequest=10100

Check warning on line 62 in src/gui/systray.h

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Class has 87 methods, which is greater than the 35 authorized. Split it into smaller classes. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ9MigxJjuOfYSgZmLiu&open=AZ9MigxJjuOfYSgZmLiu&pullRequest=10100

Check warning on line 737 in src/gui/application.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Unmodified variable "cfg" of type "class OCC::ConfigFile" should be const-qualified. 

See more on https://sonarcloud.io/project/issues?id=nextcloud_desktop&issues=AZ9MigwVjuOfYSgZmLik&open=AZ9MigwVjuOfYSgZmLik&pullRequest=10100
View more details on SonarQubeCloud