Skip to content

Add mikrotik_routeros_interface_lte_apn_print_terse#2287

Open
kwood92 wants to merge 3 commits into
networktocode:masterfrom
kwood92:mikrotik_routeros_interface_lte_apn_print_terse
Open

Add mikrotik_routeros_interface_lte_apn_print_terse#2287
kwood92 wants to merge 3 commits into
networktocode:masterfrom
kwood92:mikrotik_routeros_interface_lte_apn_print_terse

Conversation

@kwood92

@kwood92 kwood92 commented Feb 18, 2026

Copy link
Copy Markdown
Contributor

Adds support for /interface lte print terse

@mjbear mjbear changed the title Add: mikrotik_routeros_interface_lte_print_terse Add mikrotik_routeros_interface_lte_apn_print_terse Feb 21, 2026
Comment thread ntc_templates/templates/mikrotik_routeros_interface_lte_apn_print_terse.textfsm Outdated
@mjbear mjbear requested a review from jvanderaa March 11, 2026 23:39

@matt852 matt852 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Recommendation: Changes Suggested

Breaking Change: No

Thanks @kwood92 — this is in great shape, and the earlier whitespace/error-rule fixes look good. Two suggestions before merge, both to make the template parse real-world APN tables and not just the builtin default entry:

  • FLAGS only matches the default * and is required. As written, a user-added APN (no flag) or a disabled one (X) won't parse. The other mikrotik _terse templates capture flags as a multi-char, optional column — recommend matching that.

    In mikrotik_routeros_interface_lte_apn_print_terse.textfsm, the Value declaration:

    -Value FLAGS (\*)
    +Value FLAGS ([X\*]+)

    And the matching rule in Start, making the flag column optional:

    - ^${INDEX}\s+${FLAGS}\s+name=${NAME}\s+apn=${APN}...
    + ^${INDEX}\s+(${FLAGS}\s+)?name=${NAME}\s+apn=${APN}...
  • IP_TYPE can't match ipv4-ipv6. RouterOS supports a dual-stack ip-type=ipv4-ipv6, which the closed (auto|ipv4|ipv6) alternation would fail on. Simplest is to broaden it (the existing ipv4 sample still parses unchanged):

    -Value IP_TYPE (auto|ipv4|ipv6)
    +Value IP_TYPE (\S+)

    (If you'd rather keep the alternation for validation, add ipv4-ipv6 to it and include raw rows that exercise each option.)

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants