Skip to content

feat!: update default Node.js version to 24#7103

Open
hrishikesh-k wants to merge 6 commits into
mainfrom
hk/frb-2272
Open

feat!: update default Node.js version to 24#7103
hrishikesh-k wants to merge 6 commits into
mainfrom
hk/frb-2272

Conversation

@hrishikesh-k

Copy link
Copy Markdown
Contributor

Do not merge, needs a co-ordinated release

https://linear.app/netlify/issue/FRB-2272/ (follow-up of #5958)

**Do not merge, needs a co-ordinated release**

https://linear.app/netlify/issue/FRB-2272/ (follow-up of #5958)
@hrishikesh-k hrishikesh-k requested a review from a team as a code owner June 23, 2026 16:39
@coderabbitai

coderabbitai Bot commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 709eb781-aeb1-41c1-9b0e-1d407dd8fde6

📥 Commits

Reviewing files that changed from the base of the PR and between 52054a1 and 0a30c0a.

📒 Files selected for processing (1)
  • packages/zip-it-and-ship-it/src/runtimes/node/bundlers/esbuild/bundler_target.ts
🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

  • netlify/blueprints (manual)
✅ Files skipped from review due to trivial changes (1)
  • packages/zip-it-and-ship-it/src/runtimes/node/bundlers/esbuild/bundler_target.ts

📝 Walkthrough

Summary by CodeRabbit

  • Chores
    • Updated the default Node.js version from 22 to 24 when no Node version is configured, changing fallback behavior and supported-version calculations.
  • Compatibility
    • Added Node.js 24 support for selecting the appropriate esbuild bundler target preset.
  • Tests
    • Updated unit and API tests to reflect updated Node.js 24 runtime fallback and version-to-target/runtime mappings.

Walkthrough

The default Node.js major version constant is updated from 22 to 24 in packages/zip-it-and-ship-it/src/runtimes/node/utils/node_version.ts. This constant serves as the fallback when getNodeVersion receives no config version. The esbuild bundler target mapping in packages/zip-it-and-ship-it/src/runtimes/node/bundlers/esbuild/bundler_target.ts is extended with a new entry to map Node version 24 to the string 'node24', enabling the bundler to target Node 24. Unit test expectations in node_runtime.test.ts are updated to reflect that inputs without explicit versions now resolve to nodejs24.x instead of nodejs22.x. Integration test cases in v2api.test.ts for older and invalid Node version scenarios are updated to expect the nodejs24.x fallback.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description is largely incomplete, missing the required 'Summary' section with issue reference and motivation. It only contains a note about coordination requirements and issue references. Complete the description by adding a 'Summary' section that explains the motivation, fixes the referenced issue number, and follows the repository's PR template structure.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: updating the default Node.js version to 24, marked as a breaking change.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch hk/frb-2272

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown
Contributor

e18e dependency analysis

No dependency warnings found.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants