Skip to content

fix: remove dead logModulesWithDynamicImports#7077

Open
serhalp wants to merge 2 commits into
mainfrom
fix/remove-dead-dynamic-imports-code
Open

fix: remove dead logModulesWithDynamicImports#7077
serhalp wants to merge 2 commits into
mainfrom
fix/remove-dead-dynamic-imports-code

Conversation

@serhalp

@serhalp serhalp commented May 28, 2026

Copy link
Copy Markdown
Member

Summary

This was orphaned years ago by ef4ab12c3.

@coderabbitai

coderabbitai Bot commented May 28, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: fd1f287d-6129-4eb2-84f2-ab385163bbaa

📥 Commits

Reviewing files that changed from the base of the PR and between a78f88d and a63355e.

📒 Files selected for processing (1)
  • packages/build/src/log/messages/core_steps.js
🔗 Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

  • netlify/blueprints (manual)
🚧 Files skipped from review as they are similar to previous changes (1)
  • packages/build/src/log/messages/core_steps.js

📝 Walkthrough

Summary by CodeRabbit

  • Bug Fixes

    • Removed an incorrect warning about dynamic module imports from build logs, resulting in clearer and more accurate build output.
  • Chores

    • Simplified internal bundling metrics and warning generation related to dynamic import detection.

Walkthrough

This PR removes the dynamic imports warning logging feature from the bundle results handler. The logBundleResults function no longer derives modulesWithDynamicImports, no longer calls logModulesWithDynamicImports, and the helper function is deleted. The existing error and warning logging remains unchanged.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description only gives a brief summary and omits the required issue reference, motivation, and checklist sections from the template. Add the Fixes #issue line, explain why the code was orphaned, and complete the required checklist and documentation sections.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly states the main change: removing dead logModulesWithDynamicImports code.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/remove-dead-dynamic-imports-code

Warning

Review ran into problems

🔥 Problems

Linked repositories: Couldn't analyze netlify/blueprints - clone failed: Clone operation failed: Cloning into '/home/jailuser/git'...
warning: templates not found in /usr/share/git-core/templates
remote: Repository not found.
fatal: repository 'https://github.com/netlify/blueprints.git/' not found


Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown
Contributor

This pull request adds or modifies JavaScript (.js, .cjs, .mjs) files.
Consider converting them to TypeScript.

@serhalp serhalp marked this pull request as ready for review May 28, 2026 14:09
@serhalp serhalp requested a review from a team as a code owner May 28, 2026 14:09
@coderabbitai

coderabbitai Bot commented May 28, 2026

Copy link
Copy Markdown
Contributor

Actionable comments posted: 0

@serhalp serhalp requested a review from pieh June 24, 2026 14:52
@serhalp serhalp enabled auto-merge (squash) June 24, 2026 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant