Repository navigation
Conversation
_vendor.scss imports the full bootstrap-sass stylesheet, which emits a @font-face for Glyphicons Halflings pointing at ../fonts/bootstrap/glyphicons-halflings-regular.*. Those font files were never copied into the dist, so the references 404 (and Symfony AssetMapper warns about every missing file). The glyphicons are in use: .glyphicon-* classes appear in slider.hbs and block_actions.hbs. Add a Grunt copy:vendor rule that copies the bootstrap-sass glyphicons fonts into <dist>/fonts/bootstrap, and include the built font files so the fix takes effect without a rebuild. Fixes netgen-layouts#9 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Member
|
Hi! If you can, can you give me some examples of pages where this issue produces 404s? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9.
app/styles/_vendor.scssimports the full bootstrap-sass stylesheet:bootstrap-sass's
_glyphicons.scssemits a@font-face(default$icon-font-path: "bootstrap/") that resolves, frompublic/css/, to../fonts/bootstrap/glyphicons-halflings-regular.{eot,woff2,woff,ttf,svg}. Those font files were never produced: thecopy:disttask only copiesapp/fonts/**, andapp/fonts/has nobootstrap/subdir. Result: the references 404 at runtime (glyphicon icons render as empty boxes) and Symfony AssetMapper warns about each missing file duringasset-map:compile.The glyphicons are genuinely in use —
.glyphicon-*classes appear inapp/templates/slider.hbsandapp/templates/block_actions.hbs— so removing them isn't the right fix; the fonts just need to ship.Changes
copy:vendorrule copyingnode_modules/bootstrap-sass/assets/fonts/bootstrap→<dist>/fonts/bootstrap, mirroring the existing ace-editor/ckeditor/media rules.bootstrap-sass@3.4.1, the version already pinned inpackage.json) so the fix is effective on pull without requiring a rebuild.Verification
The committed
woff2matches the upstream bootstrap-sass asset (md5 448c34a56d699c29117adc64c43affeb), and the filenames match the@font-facesrcURLs innetgen-layouts.css.