feat(cli): get remaining flags now returns empty when no flag is found#3468
Open
QusaiAlbonni wants to merge 1 commit into
Open
feat(cli): get remaining flags now returns empty when no flag is found#3468QusaiAlbonni wants to merge 1 commit into
QusaiAlbonni wants to merge 1 commit into
Conversation
5 tasks
Member
|
could you add an e2e test? |
Author
just to be clear an e2e test for the case of -no- in argv[0] just like the original issue? if so yes I can. |
Member
|
an e2e test which confirms that if you run a command with a path containing -no- it doesnt fail |
ceadc01 to
c1b0664
Compare
c1b0664 to
3ed7aee
Compare
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #3466
What is the new behavior?
getRemainingFlagsnow returns an empty array when no flags are found instead of returning all arguments.In v11/master this behavior contributes to a downstream failure and is therefore treated as a bug fix. However, in the v12 branch, #3355 modified camelCase to handle these values safely, so the incorrect return value and processing of it no longer causes a user-visible failure. As a result, this change is classified as an enhancement/semantic correction rather than a bug fix as it might prevent future bugs from emerging.
Does this PR introduce a breaking change?
Other information