Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Summary
Adds a FIPS 140-3 compliant container image for
jetstream-controller, published asjetstream-controller:<tag>-fipsalongside the existing images. Built with Go's native, CMVP-validated Go Cryptographic Module v1.0.0 (Certificate #5247) viaGOFIPS140=v1.0.0— no cgo, no toolchain fork, no changes to the existing (non-FIPS) builds.Changes
.goreleaser.yml: newjetstream-controller-fipsbuild id — same source and ldflags, built withGOFIPS140=v1.0.0and running in FIPS mode by default (fips140=on). Binary is namedjetstream-controller-fipsbecausecicd/Dockerfileselects artifacts by binary name.docker-bake.hcl:jetstream-controller-fipstarget (in thedefaultgroup, so CI picks it up with no workflow changes), reusingcicd/Dockerfileunchanged./usr/local/bin/jetstream-controllerand/jetstream-controller→ the FIPS binary (viadockerfile-inline, same pattern asnats-boot-config), so command/path overrides keep working.get_tags_suffix()for the-fipstag scheme,get_platforms_fips()for the reduced platform matrix.Verification
goreleaser checkanddocker buildx bake --printpass.--versionvia the compat symlink (FIPS module self-tests execute at startup).go version -mon the extracted binary confirms linkage:GOFIPS140=v1.0.0, build tagfips140v1.0,DefaultGODEBUG=…fips140=on….GODEBUG=fips140=only GOFIPS140=v1.0.0 make test