Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RecognizeOptionsas extendingWorkerParamsso Tesseract parameters can be passed toworker.recognizeandscheduler.addJob('recognize', ...)without a type error (Fix types for setting Tesseract parameters inrecognize聽#856).worker.setParameters).tessedit_pageseg_mode: "6"as well asPSM.SINGLE_BLOCK, matching the issue snippet.Per-job parameters have been supported at runtime since v4 (#665):
src/worker-script/index.jsalready splitsoptionsinto Tesseract.js keys and pass-throughSetVariablecalls, thenRestoreParameters.scheduler.addJob('recognize')is typed asParameters<Worker['recognize']>, so fixingRecognizeOptionsfixes the scheduler call site in the issue.What I chose and the alternative
RecognizeOptions extends WorkerParams. Alternative: only add[propName: string]: anyonRecognizeOptions. That would silence the excess-property error but would not autocompletetessedit_*. Happy to switch.tessedit_pageseg_mode: PSM | \${PSM}`. Alternative: keepPSMand require the enum member. The issue example uses"6"`, which TypeScript string enums reject. Happy to drop the union.Test plan
scheduler.addJob('recognize', image, { tessedit_pageseg_mode: "6" })typechecksworker.recognize(image, { tessedit_pageseg_mode: PSM.SINGLE_BLOCK })typechecksworker.recognize(image, { tessedit_char_whitelist: 'Tess', rectangle: { ... } })typechecksworker.recognizewithtessedit_char_whitelistin options returns the filtered text, and the next job without that option returns the full textnpm test(Chrome + Firefox), not run in this change; Node mocha onlyFixes #856