Repository navigation
Conversation
Signed-off-by: zloglevel <loglevel@outlook.com>
Author
|
@Balearica Could you please take a look when you have a chance? Thanks! |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scheduler.terminate()Problem
scheduler.terminate()currently uses an async callback withArray.prototype.forEach():forEach()does not await the promises returned by its callback. As a result,await scheduler.terminate()can complete before the workers' termination promises have settled.The method also clears
jobQueuedirectly. Each queued entry closes over theresolveandrejectfunctions of the Promise returned byaddJob(). Removing those entries without rejecting them leaves the corresponding job promises permanently pending.Solution
Store each queued job's
runandrejectfunctions. During termination:Promise.all()Queued jobs are rejected with a
Scheduler terminatederror.Tests
scheduler.terminate()waits for worker terminationnpm run lintnpm test