Skip to content

Migrate to IDF v5.5.5#3491

Open
josesimoes wants to merge 5 commits into
nanoframework:mainfrom
josesimoes:migrate-idf-5.5.5
Open

Migrate to IDF v5.5.5#3491
josesimoes wants to merge 5 commits into
nanoframework:mainfrom
josesimoes:migrate-idf-5.5.5

Conversation

@josesimoes

Copy link
Copy Markdown
Member

Description

  • Update CMake, dev containers.
  • Bump version numbers.

Motivation and Context

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue with code or algorithm)
  • New feature (non-breaking change which adds functionality to code)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dev Containers (changes related with Dev Containers, has no impact on code or features)
  • Dependencies/declarations (update dependencies or assembly declarations and changes associated, has no impact on code or features)
  • Documentation (changes or updates in the documentation, has no impact on code or features)

Checklist

  • My code follows the code style of this project (only if there are changes in source code).
  • My changes require an update to the documentation (there are changes that require the docs website to be updated).
  • I have updated the documentation accordingly (the changes require an update on the docs in this repo).
  • I have read the CONTRIBUTING document.
  • I have tested everything locally and all new and existing tests passed (only if there are changes in source code).

- Update CMake, dev containers.
- Bump version numbers.
@josesimoes josesimoes added the Platform: ESP32 Everything related specifically with ESP32 platform label Jul 22, 2026
@nfbot nfbot added Area: Config-and-Build Area: Dev-Containers Type: dependencies Pull requests that update a dependency file(s) or version labels Jul 22, 2026
@coderabbitai

coderabbitai Bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Warning

Review limit reached

@josesimoes, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 10 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: ASSERTIVE

Plan: Pro

Run ID: 01d87020-0360-478c-b252-971ff01e14ed

📥 Commits

Reviewing files that changed from the base of the PR and between 19703a6 and 36f03d2.

📒 Files selected for processing (1)
  • CMake/binutils.ESP32.cmake
📝 Walkthrough

Walkthrough

Updates the project release version to 1.18.0, advances pipeline revision counters, upgrades development container images, and aligns ESP-IDF references and source checkouts to v5.5.5. ESP32 Bluetooth include paths and ESP32P4 component registry identifiers are also updated.

Changes

Release and toolchain updates

Layer / File(s) Summary
Release version and pipeline counters
version.json, azure-pipelines.yml
The project version changes from 1.17.0 to 1.18.0, and target pipeline revision counter keys advance to the 1.18.0 series.
ESP-IDF 5.5.5 alignment
.devcontainer/..., CMake/riscv-esp32p4.json, targets/ESP32/CMakeLists.txt, azure-pipelines*.yml, .github/copilot-instructions.md
ESP-IDF source checkouts, build configuration, pipeline tags, and documented SDK versions change to v5.5.5; development container images are also updated.
ESP32 component configuration
CMake/Modules/FindnanoFramework.Device.Bluetooth.cmake, CMake/binutils.ESP32.cmake
Bluetooth include paths and ESP32P4 registry component identifiers are updated.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested labels: Type: documentation

Suggested reviewers: adriansoundy

🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: migrating to IDF v5.5.5.
Description check ✅ Passed The description is related to the changeset and matches the version bumps and dev container updates.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@targets/ESP32/CMakeLists.txt`:
- Line 50: Update the ESP32_IDF_TAG cache definition to force its value on every
configuration, ensuring reused build directories replace stale IDF tag entries
with 5.5.5.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: ASSERTIVE

Plan: Pro

Run ID: edd302d4-ec27-4bb5-bc78-aeec35996636

📥 Commits

Reviewing files that changed from the base of the PR and between e49f01c and 30e5b25.

📒 Files selected for processing (10)
  • .devcontainer/All/Dockerfile.All
  • .devcontainer/All/Dockerfile.All.SRC
  • .devcontainer/ESP32/Dockerfile.ESP32
  • .devcontainer/ESP32/Dockerfile.ESP32.SRC
  • .github/copilot-instructions.md
  • CMake/riscv-esp32p4.json
  • azure-pipelines-nightly.yml
  • azure-pipelines.yml
  • targets/ESP32/CMakeLists.txt
  • version.json

Comment thread targets/ESP32/CMakeLists.txt Outdated
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: Config-and-Build Area: Dev-Containers Platform: ESP32 Everything related specifically with ESP32 platform Type: dependencies Pull requests that update a dependency file(s) or version

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants