Moving to C23 and C++23

src/CLR/Core/CLR_RT_HeapBlock_Array.cpp

@@ -329,7 +329,7 @@ HRESULT CLR_RT_HeapBlock_Array::Copy(
                 dataDst + length * sizeElem > arrayDst->GetFirstElement() + arrayDst->m_numOfElements * sizeElem)
             {
 #ifdef DEBUG
-                _ASSERTE(FALSE);
+                _ASSERTE(false);
 #endif
 
                 NANOCLR_SET_AND_LEAVE(CLR_E_OUT_OF_RANGE);

src/CLR/Diagnostics/Diagnostics_stub.cpp

@@ -35,7 +35,7 @@ __nfweak bool CLR_SafeSprintfV(char *&szBuffer, size_t &iBuffer, const char *for
 
     NATIVE_PROFILE_CLR_DIAGNOSTICS();
 
-    return FALSE;
+    return false;
 }
 
 __nfweak bool CLR_SafeSprintf(char *&szBuffer, size_t &iBuffer, const char *format, ...)
@@ -46,7 +46,7 @@ __nfweak bool CLR_SafeSprintf(char *&szBuffer, size_t &iBuffer, const char *form
 
     NATIVE_PROFILE_CLR_DIAGNOSTICS();
 
-    return FALSE;
+    return false;
 }
 
 //--//

src/DeviceInterfaces/Network/Enc28j60/enc28j60_lwip.cpp

@@ -540,7 +540,7 @@ err_t enc28j60_lwip_xmit(struct netif *pNetIF, struct pbuf *pPBuf)
     if (length > ETHERSIZE) // (ETHERSIZE+4))
     {
         debug_printf("xmit - length is too large, truncated \r\n");
-        ASSERT(FALSE);
+        ASSERT(false);
         length = ETHERSIZE; // ETHERSIZE+4;         /* what a terriable hack! */
     }
 
@@ -928,7 +928,7 @@ bool enc28j60_lwip_setup_device(struct netif *pNetIF)
         ENC28J60_ECON1,
         (uint8_t)(1 << ENC28J60_ECON1_RXEN_BIT));
 
-    return TRUE;
+    return true;
 }
 
 void enc28j60_lwip_destroy_device()

src/DeviceInterfaces/Network/Enc28j60/enc28j60_lwip_driver.cpp

@@ -5,7 +5,7 @@
 //
 
 #include <nanohal.h>
-//#include "net_decl_lwip.h"
+// #include "net_decl_lwip.h"
 #include "enc28j60_lwip.h"
 
 extern "C"
@@ -22,7 +22,7 @@ static struct netif g_ENC28J60_NetIF;
 
 HAL_CONTINUATION InterruptTaskContinuation;
 HAL_COMPLETION LwipUpTimeCompletion;
-static bool LwipNetworkStatus = FALSE;
+static bool LwipNetworkStatus = false;
 static uint32_t LwipLastIpAddress = 0;
 
 extern ENC28J60_LWIP_DEVICE_CONFIG g_ENC28J60_LWIP_Config;
@@ -206,7 +206,7 @@ bool enc28j60_Network_Interface_Close(int index, HAL_Configuration_NetworkInterf
 {
     NATIVE_PROFILE_HAL_DRIVERS_ETHERNET();
     if (pConfig->SpecificConfigId >= ARRAYSIZE(g_ENC28J60_LWIP_Config.DeviceConfigs))
-        return FALSE;
+        return false;
 
     return g_ENC28J60_LWIP_Driver.Close(&g_ENC28J60_LWIP_Config.DeviceConfigs[pConfig->SpecificConfigId], index);
 }

src/DeviceInterfaces/System.Net/sys_net_native_System_Net_Security_CertificateManager.cpp

@@ -53,7 +53,7 @@ HRESULT Library_sys_net_native_System_Net_Security_CertificateManager::
                 0,
                 certificateSize,
                 0,
-                true) != TRUE)
+                true) != true)
         {
             NANOCLR_SET_AND_LEAVE(CLR_E_FAIL);
         }
@@ -70,7 +70,7 @@ HRESULT Library_sys_net_native_System_Net_Security_CertificateManager::
     }
 
     // reach here, we should be OK
-    stack.SetResult_Boolean(TRUE);
+    stack.SetResult_Boolean(true);
 
     NANOCLR_CLEANUP();
 

src/DeviceInterfaces/System.Net/sys_net_native_System_Net_Security_SslNative.cpp

@@ -223,7 +223,7 @@ HRESULT Library_sys_net_native_System_Net_Security_SslNative::ExitSecureContext_
 
     CLR_INT32 sslContext = stack.Arg0().NumericByRef().s4;
 
-    int result = SSL_ExitContext(sslContext) == TRUE ? 0 : -1;
+    int result = SSL_ExitContext(sslContext) == true ? 0 : -1;
 
     stack.SetResult_I4(result);
 

src/DeviceInterfaces/System.Net/sys_net_native_System_Net_Sockets_NativeSocket.cpp

@@ -489,7 +489,7 @@ CLR_INT32 Library_sys_net_native_System_Net_Sockets_NativeSocket::Helper__Select
             writefds = &fds;
             break;
         default:
-            _ASSERTE(FALSE);
+            _ASSERTE(false);
             // fall through
         case 2:
             exceptfds = &fds;

src/HAL/Include/nanoHAL_Graphics.h

@@ -8,7 +8,7 @@
 
 #include <target_platform.h>
 
-#if (NANOCLR_GRAPHICS == TRUE)
+#if NANOCLR_GRAPHICS
 #include "Display.h"
 #include "DisplayInterface.h"
 #include "TouchDevice.h"

src/HAL/nanoHAL_SystemInformation.cpp

@@ -14,7 +14,7 @@ bool GetHalSystemInfo(HalSystemInfo &systemInfo)
 {
 #if defined(HAL_REDUCESIZE)
     // No config update.
-    return FALSE;
+    return false;
 #else
 
     // NFReleaseInfo:
@@ -44,7 +44,7 @@ bool GetHalSystemInfo(HalSystemInfo &systemInfo)
         (char *)&systemInfo.m_OemSerialNumbers.system_serial_number,
         sizeof(systemInfo.m_OemSerialNumbers.system_serial_number));
 
-    return TRUE;
+    return true;
 #endif
 }
 
@@ -62,7 +62,7 @@ bool Target_GetReleaseInfo(NFReleaseInfo &releaseInfo)
         hal_strlen_s(TARGETNAMESTRING),
         PLATFORMNAMESTRING,
         hal_strlen_s(PLATFORMNAMESTRING));
-    return TRUE; // alternatively, return false if you didn't initialize the releaseInfo structure.
+    return true; // alternatively, return false if you didn't initialize the releaseInfo structure.
 }
 
 bool DebuggerIsConnected()

src/PAL/AsyncProcCall/AsyncCompletions.cpp

@@ -242,7 +242,7 @@ void HAL_COMPLETION::Uninitialize()
 
     GLOBAL_LOCK();
 
-    while (TRUE)
+    while (true)
     {
         ptr = (HAL_COMPLETION *)g_HAL_Completion_List.ExtractFirstNode();
 

src/PAL/AsyncProcCall/AsyncContinuations.cpp

@@ -94,7 +94,7 @@ void HAL_CONTINUATION::Uninitialize()
 
     HAL_CONTINUATION *ptr;
 
-    while (TRUE)
+    while (true)
     {
         ptr = (HAL_CONTINUATION *)g_HAL_Continuation_List.ExtractFirstNode();
 

src/PAL/AsyncProcCall/Async_stubs.cpp

@@ -19,7 +19,7 @@ __nfweak void HAL_CONTINUATION::Uninitialize()
     NATIVE_PROFILE_PAL_ASYNC_PROC_CALL();
 }
 
-__nfweak void HAL_CONTINUATION::InitializeCallback( HAL_CALLBACK_FPN entryPoint, void* argument )
+__nfweak void HAL_CONTINUATION::InitializeCallback(HAL_CALLBACK_FPN entryPoint, void *argument)
 {
     (void)entryPoint;
     (void)argument;
@@ -32,15 +32,15 @@ __nfweak void HAL_CONTINUATION::Enqueue()
     NATIVE_PROFILE_PAL_ASYNC_PROC_CALL();
 }
 
-__nfweak void HAL_CONTINUATION::Abort  ()
+__nfweak void HAL_CONTINUATION::Abort()
 {
     NATIVE_PROFILE_PAL_ASYNC_PROC_CALL();
 }
 
 __nfweak bool HAL_CONTINUATION::Dequeue_And_Execute()
 {
     NATIVE_PROFILE_PAL_ASYNC_PROC_CALL();
-    return TRUE;
+    return true;
 }
 
 __nfweak bool HAL_CONTINUATION::IsLinked()
@@ -62,14 +62,14 @@ __nfweak void HAL_COMPLETION::Uninitialize()
     NATIVE_PROFILE_PAL_ASYNC_PROC_CALL();
 }
 
-__nfweak void HAL_COMPLETION::EnqueueTicks( uint64_t eventTimeTicks)
+__nfweak void HAL_COMPLETION::EnqueueTicks(uint64_t eventTimeTicks)
 {
     (void)eventTimeTicks;
 
     NATIVE_PROFILE_PAL_ASYNC_PROC_CALL();
 }
 
-__nfweak void HAL_COMPLETION::EnqueueDelta( uint32_t uSecFromNow )
+__nfweak void HAL_COMPLETION::EnqueueDelta(uint32_t uSecFromNow)
 {
     (void)uSecFromNow;
 
@@ -91,7 +91,7 @@ __nfweak void HAL_COMPLETION::DequeueAndExec()
     NATIVE_PROFILE_PAL_ASYNC_PROC_CALL();
 }
 
-__nfweak void HAL_COMPLETION::WaitForInterrupts( uint64_t expireTimeInSysTicks, uint32_t sleepLevel, uint64_t wakeEvents )
+__nfweak void HAL_COMPLETION::WaitForInterrupts(uint64_t expireTimeInSysTicks, uint32_t sleepLevel, uint64_t wakeEvents)
 {
     (void)expireTimeInSysTicks;
     (void)sleepLevel;

src/PAL/BlockStorage/nanoPAL_BlockStorage.c

@@ -452,7 +452,7 @@ bool BlockStorageStream_Read(BlockStorageStream *stream, unsigned char **buffer,
         {
             // TODO FIXME
             // need to check implementation of this call to get pointers to stream continuation
-            // if(!NextStream()) return FALSE;
+            // if(!NextStream()) return false;
         }
 
         if ((stream->CurrentIndex + readLen) > stream->Length)