fix: normalize AT%KEYGEN CSRs - #88
Merged
Merged
Conversation
Both nRF91 MFW 1.3.7 and 2.0.2 incorrectly encode CSRs with a SignatureAlgorithm as
SEQUENCE {
OID ecdsa-with-SHA256
NULL
}
Include a fix that normalizes the format before passing it to cryptography's parser.
Python cryptography older than version 49 did not complain about the format.
Signed-off-by: Maximilian Deubel <maximilian.deubel@nordicsemi.no>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both nRF91 MFW 1.3.7 and 2.0.2 incorrectly encode CSRs with a SignatureAlgorithm as
SEQUENCE {
OID ecdsa-with-SHA256
NULL
}
Include a fix that normalizes the format before passing it to cryptography's parser. Python cryptography older than version 49 did not complain about the format.