refactor: simplify docsrs cfg#105
Merged
Merged
Conversation
rklaehn
approved these changes
Jul 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cleans up the feature-gate doc machinery left over from the quic-rpc origins.
doc(cfg(...))annotations. Rustdoc now infers feature badges from the real#[cfg(...)]gates automatically.doc_auto_cfgwas merged intodoc_cfgin Rust 1.92 (rust-lang/rust#138907), so it is the default whenfeature(doc_cfg)is on.feature(doc_cfg)is nightly-only, but it is gated behind theirpc_docsrscfg that only docs.rs sets. Regular builds never see it, so our MSRV stays at 1.91 on stable.quicrpc_docsrstoirpc_docsrs, matching the crate name and theiroh_docsrsconvention.We keep a crate-specific cfg rather than the common
docsrsbecause--cfg docsrsleaks into dependencies. A full doc build fails whencordycepsenables now-removed features behind#[cfg(docsrs)]. Usingirpc_docsrssidesteps that.