fix(env): register DEGRADED_TRANSCRIPT_THRESHOLD so .env value is picked up#807
Merged
mvanhorn merged 1 commit intoJul 15, 2026
Conversation
…ked up
DEGRADED_TRANSCRIPT_THRESHOLD was missing from env.py's keys tuple,
so config.get('DEGRADED_TRANSCRIPT_THRESHOLD') in quality_nudge.py:205
always returned None, silently falling through to the hardcoded
DEFAULT_DEGRADED_TRANSCRIPT_THRESHOLD (0.5) regardless of the user's
.env setting.
Closes mvanhorn#806
Contributor
Greptile SummaryThis PR makes the degraded transcript threshold configurable through the existing environment loader. The main change is:
Confidence Score: 5/5This looks safe to merge.
Important Files Changed
Reviews (1): Last reviewed commit: "fix(env): register DEGRADED_TRANSCRIPT_T..." | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
DEGRADED_TRANSCRIPT_THRESHOLDis used viaconfig.get("DEGRADED_TRANSCRIPT_THRESHOLD")inquality_nudge.py:205but is never registered inenv.py's keys tuple. Users who set this in their.envfile find it silently ignored —config.get(...)always returnsNone, falling through to the hardcodedDEFAULT_DEGRADED_TRANSCRIPT_THRESHOLD(0.5) regardless of what the user configured.This is the same pattern as the previously fixed
FUN_LEVEL(PR #708) andLAST30DAYS_REPORT_CACHE_TTL_SECONDS(PR #732) — a user-facing env var referenced byconfig.get()but absent from the keys list.Change
env.py: Added('DEGRADED_TRANSCRIPT_THRESHOLD', None)to theget_config()keys tuple next to the other YouTube/transcript-related keys.No KEYCHAIN_KEYS or setup-script change needed — it is not a credential.
Verification