fix: log _load_last_report_cache failure to stderr instead of silent swallow (#787)#788
Open
23241a6749 wants to merge 2 commits into
Open
fix: log _load_last_report_cache failure to stderr instead of silent swallow (#787)#78823241a6749 wants to merge 2 commits into
23241a6749 wants to merge 2 commits into
Conversation
…swallow The _load_last_report_cache function caught all exceptions and returned None (cache miss) without any diagnostic output. If the cache file is corrupted, truncated, or contains unexpected data, users had no way to know why the cache was being regenerated on every run. Now logs the exception to stderr before falling through to the cache-miss path, so automated and interactive users alike can diagnose the issue. Fixes mvanhorn#787.
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_load_last_report_cache()caught allExceptionand silently returnedNone(cache miss) with zero diagnostic output. If the cache file at~/.config/last30days/last-report.jsonis corrupted, truncated, or version-mismatched, users had no way to know why the cache was being regenerated on every run — wasted token spend and lost performance.Change
last30days.py:762-763— replacedexcept Exception: return Nonewith: