Avoid empty auto-announce after queue ends - #1316
Merged
Merged
Conversation
馃摝 馃 A new release has been made for this pull request.To play around with this PR, pull Images are available for x86_64 and ARM64.
|
|
馃殌 Released in Release v2.11.5. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Avoid sending an empty auto-announce message when playback reaches the end of the queue.
Details
When
autoAnnounceNextSongis enabled, the audio idle handler advances the queue and then announces the next track. If the track that just ended was the final queue item,getCurrent()becomesnull, but Muse still attempted to send an announcement withembeds: []. Discord rejects that as an empty message, and the rejection can surface from the async audio event handler.This returns early when there is no next current song, while preserving the existing announcement behavior when a next track exists.
Related to #1314. This addresses the queue-empty auto-announce case only; it does not change the listener-leave disconnect path.
Validation
npm run lintnpm run typechecknpm run build