Skip to content

python-cryptography: drop patch disabling abi3 - #18240

Merged
lazka merged 1 commit into
msys2:masterfrom
lazka:python-cryptography-abi3
Aug 23, 2023
Merged

python-cryptography: drop patch disabling abi3#18240
lazka merged 1 commit into
msys2:masterfrom
lazka:python-cryptography-abi3

Conversation

@lazka

@lazka lazka commented Aug 22, 2023

Copy link
Copy Markdown
Member

it should work now after #18238

@lazka
lazka force-pushed the python-cryptography-abi3 branch from e5efe11 to ec903a9 Compare August 22, 2023 20:16
@MehdiChinoune

Copy link
Copy Markdown
Collaborator

@lazka

lazka commented Aug 22, 2023

Copy link
Copy Markdown
Member Author

We could also build pyside6 with Py_LIMITED_API https://github.com/msys2/MINGW-packages/blob/a7a713ce1562ece2006448680176bf6099109876/mingw-w64-pyside6/PKGBUILD

thanks, yeah. This will likely need more patching though, because pyside6 hardcodes MSVC file names from what I can see.

@lazka

lazka commented Aug 23, 2023

Copy link
Copy Markdown
Member Author

We could also build pyside6 with Py_LIMITED_API https://github.com/msys2/MINGW-packages/blob/a7a713ce1562ece2006448680176bf6099109876/mingw-w64-pyside6/PKGBUILD

thanks, yeah. This will likely need more patching though, because pyside6 hardcodes MSVC file names from what I can see.

On a second thought, the main reason the limited API exists is to allow wheel builds for pypi, which we don't do, so we don't have much to gain from it unless it allows us to remove patches like in the python-cryptography case here.

@MehdiChinoune

Copy link
Copy Markdown
Collaborator

I think that one the purposes of py_limited_api is to not rebuild packages with every new release.

@lazka

lazka commented Aug 23, 2023

Copy link
Copy Markdown
Member Author

true, that as well. Though I personally would try to rebuild it anyway to make sure things are still building fine after a major Python update.

if anyone wants to make it work, feel free :)

@lazka
lazka merged commit d99a6f6 into msys2:master Aug 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants