smoketests: add a test for the limited API - #150
Draft
lazka wants to merge 1 commit into
Draft
Conversation
This builds the test module twice, once normally and once for the limited API. In the later case we check at runtime if libpython3.dll is loaded, to make sure we are actually linked against it and not against libpython3.x.dll. This depends on both: * msys2-contrib#148 * msys2/MINGW-packages#18232
lazka
force-pushed
the
add-limited-api-test
branch
from
August 23, 2023 15:23
68fc140 to
2e31962
Compare
Member
Author
|
Since we are using the unpatched setuptools from https://github.com/msys2-contrib/cpython-mingw/tree/mingw-v3.11.4/Lib/ensurepip/_bundled this doesn't work. We could update the bundled setuptools with the patched one we use for building the MSYS2 package. |
lazka
marked this pull request as draft
August 25, 2023 14:02
Member
Author
|
With upstream setuptools having better mingw support now it might make sense to try upstreaming the py_limited_api support. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This builds the test module twice, once normally and once for the limited API. In the later case we check at runtime if libpython3.dll is loaded, to make sure we are actually linked against it and not against libpython3.x.dll.
This depends on both: