Skip to content

Fix revision compare RTL alignment #7676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
janbrasna wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Fix revision compare RTL alignment #7676

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
d6ebb1a
Align revision list button implicitly like top
janbrasna Jun 24, 2026
fc146f1
Remove duplicated backgrounds
janbrasna Jun 24, 2026
f396b01
Use bidi-aware spacing of compare button
janbrasna Jun 24, 2026
739716f
Flip arrows for RTL
janbrasna Jun 24, 2026
4137573
Fix RTL spacing of inproduct article info icon
janbrasna Jul 2, 2026
2fa190e
Fix contributor avatar spacing in RTL
janbrasna Jul 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions kitsune/sumo/static/sumo/scss/base/forms/_buttons.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,18 +169,21 @@

&.compare-revisions-button-down,
&.compare-revisions-button-up {
padding-left: p.$spacing-xs;
padding-inline-start: p.$spacing-xs;
&:before {
display: inline-flex;
align-self: flex-end;
margin-right: p.$spacing-sm;
margin-inline-end: p.$spacing-sm;
width: 58px;
height: 20px;
background-image: c.svg-url('<svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 60.41 14.4"><path fill="none" stroke="#5e5e72" stroke-miterlimit="10" stroke-width="2" d="M60.41 1H4.14v9.78M37.63 10.78V1"/><path fill="#5e5e72" d="M4.14 14.4l4.14-7.17H0l4.14 7.17zM37.63 14.4l4.14-7.17h-8.28l4.14 7.17z"/></svg>');
background-size: contain;
background-repeat: no-repeat;
background-position: center center;
content: "";
.html-rtl & {
transform: scaleX(-1);
}
}
}

Expand Down
2 changes: 1 addition & 1 deletion kitsune/sumo/static/sumo/scss/components/_avatar-group.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@
text-decoration: none;

img {
margin-right: 12px;
margin-inline-end: 12px;
width: 48px;
}
}
Expand Down
19 changes: 1 addition & 18 deletions kitsune/sumo/static/sumo/scss/components/_wiki.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ figure {
img {
width: 24px;
height: 24px;
margin-right: p.$spacing-sm;
margin-inline-end: p.$spacing-sm;
}

figcaption {
Expand Down Expand Up @@ -514,23 +514,6 @@ article {
}
}

.compare {
height: 20px;
padding: 0;
text-align: left;

&.top {
background: transparent url(../img/wiki/compare.arrows.png) no-repeat p.$spacing-xs 5px;
padding-bottom: 5px;
}

&.bottom {
background: transparent url(../img/wiki/compare.arrows.png) no-repeat p.$spacing-xs -40px;
padding-top: 10px;
}
}


.loading {
display: none;
height: 20px;
Expand Down
2 changes: 1 addition & 1 deletion kitsune/wiki/jinja2/wiki/includes/revision_list.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@
{% endif %}
{% endfor %}
{% if revisions.count() > 1 %}
<div class="sumo-button-wrap align-full compare bottom">
<div class="sumo-button-wrap">
<button type="submit" class="sumo-button compare-revisions-button-up">{% if document.parent %}{{ _('Compare Selected Translations') }}{% else %}{{ _('Compare Selected Revisions') }}{% endif %}</button>
</div>
{% endif %}
Expand Down