fix(content): only remove .fbc-wrapper when one already existed - #1014
Open
SAY-5 wants to merge 1 commit into
Open
fix(content): only remove .fbc-wrapper when one already existed#1014SAY-5 wants to merge 1 commit into
SAY-5 wants to merge 1 commit into
Conversation
openInputPrompt's hasFbcWrapper.remove() ran unconditionally outside the if/else block, so the very first badge click on a page — when no wrapper had been injected yet and one was just created — threw TypeError: hasFbcWrapper is null at content_script.js:331 and the prompt failed to open until a second click rebuilt the missing branch. Move the remove() into an else branch so it only runs when an existing wrapper is being torn down to make room for the new one. Closes mozilla#1008. Signed-off-by: SAY-5 <say.apm35@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #1008.
openInputPromptqueries for an existing.fbc-wrapperand, when one is missing, injects a fresh wrapper into the page. The trailing callwas placed outside the if/else block, so it ran unconditionally, including on the first badge click of a page when no wrapper existed and one was just created. The result was
and the prompt failed to open until a second click rebuilt the missing branch.
Fix
Move
hasFbcWrapper.remove()into anelsebranch so it only runs when an existing wrapper is being torn down to make room for the new injection.Test plan
node -c src/content_script.js, passes