bug-2060967: link crash stack source files to searchfox instead of github - #7248
Merged
Merged
Conversation
…thub Firefox symbol files now use git paths like git paths in the mozilla-firefox/firefox repository, so stack frames linked to github.com. Searchfox is preferable for reading crash stacks, so map that repository to searchfox instead. All of searchfox's firefox-* trees share a single clone which has refs for main, beta, release and the esr branches, and the /rev/ endpoint resolves any commit in that clone. Since mozilla-firefox/firefox holds every release branch, the firefox-main tree covers all channels. To express a mapping for one repository rather than a whole server, enhance_frame() now looks up the full root before falling back to the server, which leaves other github.com repositories pointing at github. While here, apply the 'show the basename' fallback whenever no mapping is found instead of only when the vcs type is unknown; previously a git: path with an unrecognized server rendered the raw 'git:server/repo:file:rev' string in the stack table.
mstange
force-pushed
the
searchfox-links
branch
from
August 13, 2026 20:33
bf59204 to
43f2f79
Compare
smarnach
approved these changes
Aug 26, 2026
smarnach
left a comment
smarnach
left a comment
Contributor
There was a problem hiding this comment.
Thanks, this looks good to me. I can't verify that this will result in correct Searchfox links in all cases, but I'm happy to try it.
github-merge-queue
Bot
removed this pull request from the merge queue due to no response for status checks
Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugzilla.mozilla.org/show_bug.cgi?id=2060967
Ever since bug 1987761 landed, Firefox symbol files now contain git paths like
git:github.com/mozilla-firefox/firefox:dom/base/StructuredCloneBlob.cpp:ed6cfb3b73cb602ed2b8a75b1721c95b8e820322. As requested in bug 2060967, let's make those link to Searchfox. Git paths to other repos, such as Rust stdlib code, will still link to github.