Improve cfg visitor - #139
Merged
Merged
Conversation
…t nodes in different visit methods This will be useful to update the way we visit the CFG. The goal is to visit all nodes inside a conditional before visiting the next nodes after the conditional. This is not done yet but this is my goal
…tional before its following blocks and introduce hooks on conditionals visits
When we have a default case in a switch, the visitor was trying to visit a non existing pattern. I added a guard
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of doing a visit depth first, I visit a full conditional block before visiting the following blocks. Then I restart the visit from the merge point.
I also added hooks to avoid code duplication if we need to add behavior during the visit