Add NXDK (Xbox) support - #139
Conversation
c944d5c to
f7ad9ef
Compare
|
I should add. I also had to make changes to NXDK to get everything working. I have not yet submitted these upstream, but will be doing so after changes here are approved. XboxDev/nxdk@master...ReenigneArcher:nxdk:moonlight (This also includes changes required for compiling OpenSSL with NXDK) |
f7ad9ef to
79b7657
Compare
I've submitted required changes to nxdk via the following PRs:
|
| #define invert_mat DECORATE_FUNC(invert_mat, ISA_SUFFIX) | ||
|
|
||
| #if defined(__x86_64__) || defined(__i386__) || (defined(_MSC_VER) && (defined(_M_IX86) || defined(_M_AMD64))) | ||
| #if !defined(NXDK) && (defined(__x86_64__) || defined(__i386__) || (defined(_MSC_VER) && (defined(_M_IX86) || defined(_M_AMD64)))) |
There was a problem hiding this comment.
What does the compiler complain about for these?
There was a problem hiding this comment.
It compiles, but the original Xbox CPU does not have these instruction sets so it always uses the _def option.
There was a problem hiding this comment.
In that case, just leave it alone and let it fall back to _def as intended.
There was a problem hiding this comment.
@cgutman so, it turns out this guard is needed for compilation to succeed on ubuntu hosts. It works without on Windows and macOS.
Maybe due to differences in clang?
- Ubuntu - Clang 18.1.3 with GNU-like command-line
- Windows - 22.1.7 (via MINGW64)
- macOS - AppleClang 17.0.0.17000013
Is it okay if I open a PR to add it back or do you have another recommendation?
79b7657 to
bb8935b
Compare
bb8935b to
30bec3f
Compare
30bec3f to
d014751
Compare
|
Did one more pass and was able to remove a couple of the guards. |
2 participants
This PR adds NXDK (Original Xbox) support. This is required for https://github.com/LizardByte/Moonlight-XboxOG
Requires cgutman/enet#24