Repository navigation
Bump moonbitlang/async to 0.22.4 - #83
Merged
Merged
Conversation
async 0.22.0 changed cancellation semantics (catch no longer captures cancellation). Audited the catch sites in main.mbt: they only convert errors into messages/exit codes, so no cleanup needs to move to defer. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
|
Automated review by Codex CLI: No actionable findings. Reviewed the requested diff and commit log.
Static review only; builds/tests were not run under the read-only constraint. VERDICT: APPROVE CI green. Merging as a low-risk dependency bump; a release follows. 🤖 Generated with Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bump
moonbitlang/asyncto 0.22.4 (latest).Since async 0.22.0,
catchno longer captures cancellation; cleanup must live indefer/errdefer. This PR bumps the dependency and audits everycatcharound async code.Change: Bump moonbitlang/async 0.20.3 → 0.22.4. No source changes.
Cancellation audit: 3
catchsites in main.mbt reviewed (stderr write, error → message/exit/abort);try!blocks let cancellation pass through. None changed.Verification: root 73 (wasm-gc, js) / 74 (native, wasm), tests 18 on all targets, debug and --release, identical before and after; the CLI regenerates tests/calc_test/calc.mbt byte-for-byte on native and wasm.
Commits:
🤖 Generated with Claude Code