Improve Worker Package Test Coverage and Fix Pre-existing Tests - #6
Improve Worker Package Test Coverage and Fix Pre-existing Tests#6moijes12 wants to merge 1 commit into
Conversation
- Unskip and fix `test_retry_missing_revision_succeeds` in `test_pulse_tasks.py` - Filter `caplog.record_tuples` in `test_stats.py` to prevent brittle failures from external logging - Add comprehensive testing to `test_task.py` for retryable tasks, standard exceptions, and New Relic integration - Achieved 100% test coverage for the `treeherder/workers` package
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
This submission improves test coverage for the
treeherder/workers/package to 100% and fixes pre-existing issues.Key Changes:
test_retry_missing_revision_succeedsintests/test_worker/test_pulse_tasks.py.tests/test_worker/test_stats.pyto filtercaploglogs by logger name, preventing brittle failures due to Google Cloud Logging diagnostic output.get_stats_client()intreeherder/workers/stats.pyto achieve 100% coverage.tests/test_worker/test_task.pyto thoroughly verify success paths, various non-retryable exceptions, and retryable exceptions with expected New Relic notice_error triggers.PR created automatically by Jules for task 7636571637100520221 started by @moijes12