Fix optional dependency imports in CI tests - #10046
Merged
tastelikefeet merged 1 commit intoSep 5, 2026
Merged
Conversation
tastelikefeet
approved these changes
Sep 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix two optional-dependency import failures without skipping tests or adding dependencies to the CI environment:
tests/llm/test_web_ui.pyunder its existing__main__guard. This file is a manual WebUI launcher, not a unittest test case. Test discovery no longer importsswift.uiand requires Gradio, while direct execution still launches the UI withWebUIArguments.Gemma3ProcessorKwargsonly in the image branch ofGemma3VisionTemplate._encode. The text-only test previously failed withModuleNotFoundError: No module named 'transformers.models.gemma3'in environments without that Transformers module, although the processor defaults are only used for images.token_type_idsassertion and execute the real vision-template encoding method.Image processing still uses the same processor defaults and still raises when its required dependency is missing. No tests are skipped, no import errors are swallowed, and no dependency requirements are changed.
This is an independent CI fix based on
main; it does not include the DPO/IPO changes from #9925 or the checkpoint-reader changes from #10045.Validation
ModuleNotFoundError.uvx pre-commit run --all-filespasses.Validation above is local and CPU-only; GPU/NPU CI results are pending.