fix(megatron): forward mtp_shared_weights to megatron-bridge - #10025
Merged
tastelikefeet merged 1 commit intoSep 1, 2026
Conversation
tastelikefeet
approved these changes
Sep 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Forward
mtp_shared_weightstomtp_use_repeated_layerwhen using themegatron-bridgebackend.The default
mcore-bridgebackend already consumes the same-name field inmcore_bridge.ModelConfig; this patch covers the provider path, where automatic name matching cannot see the renamed field.Why is this needed?
With
--mtp_num_layers N --mtp_shared_weights true,megatron-bridgepreviously leftmtp_use_repeated_layer=False, so it built independent MTP layers instead of one repeated layer.The mapping is applied only when the opt-in flag is true, so model-specific provider defaults remain unchanged when it is disabled.
Testing
compileall, Flake8, YAPF, andgit diff --checkpass.Related to #9936