Expose the middleware chain on MCPServer and stop sending unrequested change notifications - #3201
Merged
Merged
Claude / Claude Code Review
completed
Jul 28, 2026 in 17m 47s
Code review found 4 potential issues
Found 5 candidates, confirmed 4. See review comments for details.
Details
| Severity | Count |
|---|---|
| 🔴 Important | 0 |
| 🟡 Nit | 4 |
| 🟣 Pre-existing | 0 |
| Severity | File:Line | Issue |
|---|---|---|
| 🟡 Nit | docs/advanced/middleware.md:106-107 |
Middleware docs sweep missed four stale sentences that now contradict the exposed mcp.middleware surface |
Annotations
Check warning on line 107 in docs/advanced/middleware.md
claude / Claude Code Review
Middleware docs sweep missed four stale sentences that now contradict the exposed mcp.middleware surface
Four sentences missed in this PR's docs sweep now contradict the middleware surface the PR itself exposes: (1) this page's closing Recap bullet still says "Observe with it; don't build on it", contradicting the rewritten top warning (observe *and refuse*) and the new subscriptions/listen gating pitch; (2) docs/migration.md:1603 likewise still says "use middleware to observe (log, time, trace) rather than as a foundation"; (3) the "one middleware that ships on by default" section says "The SDK sh
Loading