Skip to content

Bug fixes and improvements - #707

Open
mhmdk0 wants to merge 10 commits into
mlcommons:mainfrom
mhmdk0:bug-fixes-and-improvements
Open

Bug fixes and improvements#707
mhmdk0 wants to merge 10 commits into
mlcommons:mainfrom
mhmdk0:bug-fixes-and-improvements

Conversation

@mhmdk0

@mhmdk0 mhmdk0 commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

Multiple concurrent Automatic Grant Access + fixes

Automatic Grant Access now supports multiple concurrent jobs per model+benchmark combo (was limited to one globally before), each with its own worker, interval, allow list, and viewable logs.

Also fixes:

  • Crash on every auto-grant tick (wrong kwarg name in GrantAccess.run)
  • Empty allow lists wrongly raising errors (Grant Access, Auto Grant Access, benchmark auto-approval policy) — now valid everywhere, CLI + webui
  • Root cause: FastAPI silently turned empty form fields into None, making "clear the list" indistinguishable from "don't touch it"
  • Committee members list can now be saved empty
  • Logout blocked while auto grant access is running
  • Consistent JSON error responses across the webui

@mhmdk0
mhmdk0 requested a review from a team as a code owner August 27, 2026 02:24
@mhmdk0
mhmdk0 requested a deployment to testing-external-code August 27, 2026 02:24 — with GitHub Actions Waiting
@github-actions

Copy link
Copy Markdown
Contributor

MLCommons CLA bot All contributors have signed the MLCommons CLA ✍️ ✅

return_response=return_response,
url=f"/containers/ui/display/{model_id}/access",
)
return return_response
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants