Repository navigation
fix: include non-default BLEU n-gram order in signatures - #305
Open
leeshengis wants to merge 1 commit into
Open
leeshengis wants to merge 1 commit into
leeshengis wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #251
Summary
Include
ngram:Nin BLEU reproducibility signatures whenmax_ngram_orderdiffers from the default of 4, usingn:Nfor short signatures. Default signatures remain unchanged, as discussed in the issue.This enhancement distinguishes configurations that can produce different BLEU scores. It does not change score computation.
Validation
python -m pytest --ignore=test/test_dataset.py: 194 passed (including API dataset access tests)mypy sacrebleu scripts test: passedruff check .: passedpython -m build --no-isolation: passedAI assistance was used to implement and test this change.