Repository navigation
Retry on transient network errors in download_file (fixes Windows CI WinError 10054) - #302
Merged
Merged
Conversation
…nt network errors Co-authored-by: martinpopel <724617+martinpopel@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix failing GitHub Actions job check-build (windows-latest, 3.9)
Retry on transient network errors in download_file (fixes Windows CI WinError 10054)
Aug 19, 2026
martinpopel
marked this pull request as ready for review
August 19, 2026 20:29
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Windows CI was intermittently failing with
WinError 10054(connection forcibly reset by remote host) when downloading datasets fromraw.githubusercontent.com, causing 4 tests to fail despite no code defect.Changes
sacrebleu/utils.py—download_file: Wraps theurlopencall in a retry loop (3 attempts) with exponential backoff (2^attemptseconds) onOSError(which coversurllib.error.URLErrorand Windows socket errors). SSL errors still abort immediately.