Repository navigation
Resolve chartboost/ruff-action@v1 violations across the repository - #301
Merged
Merged
Conversation
Co-authored-by: martinpopel <724617+martinpopel@users.noreply.github.com>
Co-authored-by: martinpopel <724617+martinpopel@users.noreply.github.com>
Co-authored-by: martinpopel <724617+martinpopel@users.noreply.github.com>
Co-authored-by: martinpopel <724617+martinpopel@users.noreply.github.com>
Co-authored-by: martinpopel <724617+martinpopel@users.noreply.github.com>
Co-authored-by: martinpopel <724617+martinpopel@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
martinpopel
August 18, 2026 13:19
View session
Co-authored-by: martinpopel <724617+martinpopel@users.noreply.github.com>
martinpopel
marked this pull request as ready for review
August 18, 2026 19:22
St4r4x
added a commit
to St4r4x/sacrebleu
that referenced
this pull request
Aug 19, 2026
These files predate the repo-wide ruff cleanup (mjpost#301) merged into master, so they were never covered by it. Modernizes typing (List/ Dict/Tuple -> builtin generics, Optional -> | None), sorts imports, and simplifies a min() comparison. No behavior change.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses repository-wide failures under
chartboost/ruff-action@v1by aligning code with Ruff auto-fixes and defining an explicit project lint baseline for non-actionable legacy patterns.Ruff baseline configuration
[tool.ruff.lint]config inpyproject.tomlwith a focused ignore set for rules currently incompatible with existing architecture/patterns (B019,B020,PLR1704,PLW1508,RUF012,SIM115,SIM117,TRY002,TRY203).Repository-wide autofix pass
Post-autofix correctness cleanups
Datasetconstructor handling forlangpairsto avoid type-as-default misuse while preserving runtime behavior.