Add initial support for feature flags - #244
Merged
Merged
Conversation
msiebert
reviewed
Nov 6, 2025
msiebert
approved these changes
Nov 7, 2025
tdumitrescu
reviewed
Nov 10, 2025
tdumitrescu
reviewed
Nov 11, 2025
tdumitrescu
left a comment
tdumitrescu
left a comment
Member
There was a problem hiding this comment.
Thanks for the updates, it's just about ready now
| }); | ||
| }); | ||
|
|
||
| describe('should handle special characters', function() { |
Member
There was a problem hiding this comment.
Nice. Thanks for extending test coverage
efahk
commented
Nov 12, 2025
| @@ -1,7 +1,7 @@ | |||
| { | |||
| "name": "mixpanel", | |||
Contributor
Author
There was a problem hiding this comment.
@tdumitrescu, lock file generated on install dropped a bunch of metadata. Shall i leave all of the changes made out completely?
Member
There was a problem hiding this comment.
Thanks for pointing out. @hans-lizihan merged some dep updates to master just now too, so I got this branch up to date and updated the lockfile
tdumitrescu
reviewed
Nov 12, 2025
tdumitrescu
approved these changes
Nov 12, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements a first pass at server side support for feature flagging
supports local evaluation - Flag settings are polled in the background and user assignment to specific variants is implemented on the SDK itself
remote evaluation - Each invocation to get a variant value makes a network request to the flags endpoint