Fix the spectral majorant of gridvolume and a transmittance underflow - #1959
Open
AuroraRyan0301 wants to merge 2 commits into
Open
Fix the spectral majorant of gridvolume and a transmittance underflow#1959AuroraRyan0301 wants to merge 2 commits into
AuroraRyan0301 wants to merge 2 commits into
Conversation
In spectral variants gridvolume::max() returned the largest of (c0, c1, c2, scale), and c0, c1, c2 are not densities. It now takes the scale alone.
exp(-majorant * t) underflows to zero once majorant * t passes about 87. prbvolpath and prbvolpath_sm then get 0/0 in the free flight weight tr / pdf and drop the path. The optical depth is clamped to 80 before the exponential to avoid that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two bugs in spectral variants. They give abnormal gradients.
1.
gridvolumereturns the wrong maximum. Delta tracking needs a majorant above the largest density in the grid. The medium asks the volume for it withmax(). In spectral variants an RGB grid stores four numbers per voxel: three spectral upsampling coefficients and a scale. However,max()returns the largest of (c0, c1, c2, scale), and c0, c1, c2 are not densities.Fix.
max()takes the scale alone, because the curve built from c0, c1, c2 stays between 0 and 1.2. Transmittance underflows.
exp(-majorant * t)underflows to zero oncemajorant * tpasses about 87.prbvolpathandprbvolpath_smthen get 0/0 in the free flight weighttr / pdfand drop the path, leading to black pixels.Fix. The optical depth is clamped to 80 before the exponential to avoid that.
Checklist
cuda_*andllvm_*variants. If you can't test this, please leave below