Add UV selector texture - #1881
Open
dvicini wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This adds a "UV selector" texture. This texture allows to use additional UV sets, e.g., for using light maps. While one could implement a generic solution in the
Texturebase class, I was thinking that a standalone plugin might be the better solution at the moment (given that most usecases use only the standard UV set). Supporting multiple UV sets is a meaningful step for Mitsuba to be able to ingest a broader set of existing assets. The change is contained to this one plugin and therefore very non-intrusive. The only change beyond the plugin is the addition of aneval_attribute_2API to the shape class.I am open also to naming suggestions for the plugin,
uv_set_selectoris a bit lengthy maybe.Testing
Added basic unit tests
Checklist
cuda_*andllvm_*variants. If you can't test this, please leave below