FIPS 140-3 validated password hashing — ADR, packaging, and build pipeline - #8469
FIPS 140-3 validated password hashing — ADR, packaging, and build pipeline#8469aaronlippold wants to merge 197 commits into
Quality Gate failed
Failed conditions
See analysis details on SonarQube Cloud
Annotations
Check warning on line 46 in apps/backend/src/tenable/tenable-filtering-agent.ts
sonarqubecloud / SonarCloud Code Analysis
Make sure using a hardcoded IP address 169.254.0.0 is safe here.
See more on https://sonarcloud.io/project/issues?id=mitre_heimdall2&issues=AaAMfS3Y63KyUSPF6Y_x&open=AaAMfS3Y63KyUSPF6Y_x&pullRequest=8469
Check failure on line 165 in apps/backend/src/authn/authn.service.ts
sonarqubecloud / SonarCloud Code Analysis
Refactor this function to reduce its Cognitive Complexity from 39 to the 15 allowed.
See more on https://sonarcloud.io/project/issues?id=mitre_heimdall2&issues=AaAMfTCH63KyUSPF6Y_7&open=AaAMfTCH63KyUSPF6Y_7&pullRequest=8469
Check warning on line 341 in libs/hdf-converters/src/sonarqube-mapper.ts
sonarqubecloud / SonarCloud Code Analysis
Use Array.isArray() instead of isArray() from lodash.
See more on https://sonarcloud.io/project/issues?id=mitre_heimdall2&issues=AaAMfTmQ63KyUSPF6ZAk&open=AaAMfTmQ63KyUSPF6ZAk&pullRequest=8469
Check failure on line 105 in apps/backend/src/tenable/tenable.controller.ts
sonarqubecloud / SonarCloud Code Analysis
Refactor this function to reduce its Cognitive Complexity from 22 to the 15 allowed.
See more on https://sonarcloud.io/project/issues?id=mitre_heimdall2&issues=AaAMfS3z63KyUSPF6Y_3&open=AaAMfS3z63KyUSPF6Y_3&pullRequest=8469
Check warning on line 191 in packaging/rpm/heimdall-setup.sh
sonarqubecloud / SonarCloud Code Analysis
Make sure that using clear-text protocols is safe here.
See more on https://sonarcloud.io/project/issues?id=mitre_heimdall2&issues=AZ-z-bgExHV1Enipn-yT&open=AZ-z-bgExHV1Enipn-yT&pullRequest=8469
Check warning on line 550 in apps/backend/test/constants/users-test.constant.ts
sonarqubecloud / SonarCloud Code Analysis
Review this potentially hard-coded password.
See more on https://sonarcloud.io/project/issues?id=mitre_heimdall2&issues=AaAMfTMR63KyUSPF6ZAP&open=AaAMfTMR63KyUSPF6ZAP&pullRequest=8469
Check warning on line 1204 in libs/hdf-converters/src/sonarqube-mapper.ts
sonarqubecloud / SonarCloud Code Analysis
Use Array.isArray() instead of isArray() from lodash.
See more on https://sonarcloud.io/project/issues?id=mitre_heimdall2&issues=AaAMfTmQ63KyUSPF6ZAp&open=AaAMfTmQ63KyUSPF6ZAp&pullRequest=8469
Check warning on line 198 in apps/backend/src/config/config.service.spec.ts
sonarqubecloud / SonarCloud Code Analysis
Prefer "expect(configService.getGitlabClientSecret()).toBeUndefined()" over this generic assertion; dedicated matchers read better and report clearer failures.
See more on https://sonarcloud.io/project/issues?id=mitre_heimdall2&issues=AaAMfTF263KyUSPF6Y_9&open=AaAMfTF263KyUSPF6Y_9&pullRequest=8469
Check warning on line 441 in apps/backend/test/constants/users-test.constant.ts
sonarqubecloud / SonarCloud Code Analysis
Review this potentially hard-coded password.
See more on https://sonarcloud.io/project/issues?id=mitre_heimdall2&issues=AaAMfTMR63KyUSPF6ZAH&open=AaAMfTMR63KyUSPF6ZAH&pullRequest=8469
Check failure on line 309 in apps/backend/src/authn/authn.service.ts
sonarqubecloud / SonarCloud Code Analysis
Refactor this function to reduce its Cognitive Complexity from 20 to the 15 allowed.
See more on https://sonarcloud.io/project/issues?id=mitre_heimdall2&issues=AaAMfTCH63KyUSPF6Y_8&open=AaAMfTCH63KyUSPF6Y_8&pullRequest=8469
Check warning on line 31 in apps/backend/config/app-config.ts
sonarqubecloud / SonarCloud Code Analysis
Simplify this regular expression to reduce its complexity from 25 to the 20 allowed.
See more on https://sonarcloud.io/project/issues?id=mitre_heimdall2&issues=AaAMfTPZ63KyUSPF6ZAa&open=AaAMfTPZ63KyUSPF6ZAa&pullRequest=8469
Check warning on line 340 in apps/backend/src/groups/groups.controller.spec.ts
sonarqubecloud / SonarCloud Code Analysis
Prefer "expect(evaluationsAfterRemove).toHaveLength(0)" over this generic assertion for better reporting; it works on any object with a numeric length property.
See more on https://sonarcloud.io/project/issues?id=mitre_heimdall2&issues=AaAMfTHs63KyUSPF6Y__&open=AaAMfTHs63KyUSPF6Y__&pullRequest=8469
Check warning on line 40 in libs/password-hash-vectors/src/vectors.ts
sonarqubecloud / SonarCloud Code Analysis
Review this potentially hard-coded password.
See more on https://sonarcloud.io/project/issues?id=mitre_heimdall2&issues=AaAMfTzY63KyUSPF6ZAv&open=AaAMfTzY63KyUSPF6ZAv&pullRequest=8469
Check warning on line 393 in apps/backend/src/groups/groups.controller.spec.ts
sonarqubecloud / SonarCloud Code Analysis
Prefer "expect(usersAfterRemove).toHaveLength(1)" over this generic assertion for better reporting; it works on any object with a numeric length property.
See more on https://sonarcloud.io/project/issues?id=mitre_heimdall2&issues=AaAMfTHs63KyUSPF6ZAD&open=AaAMfTHs63KyUSPF6ZAD&pullRequest=8469
Check warning on line 201 in apps/backend/src/evaluations/evaluations.service.spec.ts
sonarqubecloud / SonarCloud Code Analysis
Prefer "expect(allTags).toHaveLength(0)" over this generic assertion for better reporting; it works on any object with a numeric length property.
See more on https://sonarcloud.io/project/issues?id=mitre_heimdall2&issues=AaAMfS7x63KyUSPF6Y_5&open=AaAMfS7x63KyUSPF6Y_5&pullRequest=8469
Check failure on line 187 in apps/frontend/src/components/global/upload-tabs/tenable/FileList.vue
sonarqubecloud / SonarCloud Code Analysis
Refactor this function to reduce its Cognitive Complexity from 29 to the 15 allowed.
See more on https://sonarcloud.io/project/issues?id=mitre_heimdall2&issues=AaAMfSRJ63KyUSPF6Y_i&open=AaAMfSRJ63KyUSPF6Y_i&pullRequest=8469
Check warning on line 48 in apps/frontend/src/components/global/upload-tabs/aws/AuthStepMfa.vue
sonarqubecloud / SonarCloud Code Analysis
Replace this deprecated Vue class-based component pattern with the Composition API.
See more on https://sonarcloud.io/project/issues?id=mitre_heimdall2&issues=AaAMfSUF63KyUSPF6Y_j&open=AaAMfSUF63KyUSPF6Y_j&pullRequest=8469
Check warning on line 153 in packaging/rpm/setup-rpm-build-env.sh
sonarqubecloud / SonarCloud Code Analysis
Not enforcing HTTPS here might allow for redirections to insecure websites. Make sure it is safe here.
See more on https://sonarcloud.io/project/issues?id=mitre_heimdall2&issues=AZ-z-bazxHV1Enipn-yM&open=AZ-z-bazxHV1Enipn-yM&pullRequest=8469
Check warning on line 89 in apps/frontend/src/components/global/ExportHtmlModal.vue
sonarqubecloud / SonarCloud Code Analysis
Replace this deprecated Vue class-based component pattern with the Composition API.
See more on https://sonarcloud.io/project/issues?id=mitre_heimdall2&issues=AaAMfSkK63KyUSPF6Y_r&open=AaAMfSkK63KyUSPF6Y_r&pullRequest=8469
Check warning on line 111 in apps/backend/config/app-config.ts
sonarqubecloud / SonarCloud Code Analysis
Prefer using nullish coalescing operator (`??`) instead of a ternary expression, as it is simpler to read.
See more on https://sonarcloud.io/project/issues?id=mitre_heimdall2&issues=AaAMfTPZ63KyUSPF6ZAd&open=AaAMfTPZ63KyUSPF6ZAd&pullRequest=8469
Check warning on line 105 in apps/frontend/src/components/global/ExportCsvModal.vue
sonarqubecloud / SonarCloud Code Analysis
Replace this deprecated Vue class-based component pattern with the Composition API.
See more on https://sonarcloud.io/project/issues?id=mitre_heimdall2&issues=AaAMfScq63KyUSPF6Y_l&open=AaAMfScq63KyUSPF6Y_l&pullRequest=8469
Check warning on line 156 in apps/backend/config/app-config.ts
sonarqubecloud / SonarCloud Code Analysis
Prefer using nullish coalescing operator (`??`) instead of a ternary expression, as it is simpler to read.
See more on https://sonarcloud.io/project/issues?id=mitre_heimdall2&issues=AaAMfTPZ63KyUSPF6ZAf&open=AaAMfTPZ63KyUSPF6ZAf&pullRequest=8469
Check failure on line 69 in packaging/test-infra/fips-ec2/spike/bench.js
sonarqubecloud / SonarCloud Code Analysis
Make sure publicly writable directories are used safely here.
See more on https://sonarcloud.io/project/issues?id=mitre_heimdall2&issues=AZ_h663eC-mCpXWP97mK&open=AZ_h663eC-mCpXWP97mK&pullRequest=8469
Check warning on line 128 in apps/frontend/src/components/global/groups/GroupApiKeysModal.vue
sonarqubecloud / SonarCloud Code Analysis
Replace this deprecated Vue class-based component pattern with the Composition API.
See more on https://sonarcloud.io/project/issues?id=mitre_heimdall2&issues=AaAMfSIZ63KyUSPF6Y_h&open=AaAMfSIZ63KyUSPF6Y_h&pullRequest=8469
Check warning on line 340 in apps/frontend/src/components/global/ExportCklModal.vue
sonarqubecloud / SonarCloud Code Analysis
Replace this mixin with a Vue composable.
See more on https://sonarcloud.io/project/issues?id=mitre_heimdall2&issues=AaAMfSen63KyUSPF6Y_o&open=AaAMfSen63KyUSPF6Y_o&pullRequest=8469