-
Notifications
You must be signed in to change notification settings - Fork 17
Replace dependency @material-ui/core with @mui/material #5458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -8,7 +8,7 @@ | |
| }, | ||
| "dependencies": { | ||
| "@fancyapps/fancybox": "^3.5.7", | ||
| "@material-ui/core": "^4.2.1", | ||
| "@mui/material": "^5.0.0", | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Bug: The dependency Suggested FixFollow the official Material-UI v4 to v5 migration guide. Run the automated codemods to update package names, imports, and common API changes (e.g., Prompt for AI AgentThere was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Bug: The upgrade to Suggested FixUpdate the Prompt for AI AgentThere was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Bug: The application will fail to start because it still imports from Suggested FixUpdate all import statements throughout the codebase to use the new MUI v5 package names. For example, change imports from Prompt for AI AgentThere was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Bug: The Suggested FixUpdate all instances of the Prompt for AI Agent |
||
| "@mitodl/iso-3166-2": "^1.0.1", | ||
| "@sentry/browser": "^6.4.1", | ||
| "@sentry/webpack-plugin": "^1.18.3", | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: The dependency update to MUI v5 is incomplete. All import paths and API calls in the code still reference the old v4 package and function names, which will break the build.
Severity: CRITICAL
Suggested Fix
Update all import statements from
@material-ui/coreto the new@mui/materialpackage. Run a codemod or manually refactor the code to use the new v5 APIs, such as renamingcreateMuiThemetocreateThemeandMuiThemeProvidertoThemeProvider.Prompt for AI Agent
Did we get this right? 👍 / 👎 to inform future reviews.