Skip to content

docs(agents): .claude/settings.json に pnpm lint/test/build のパーミッションを追加 #17616

Open
fruitriin wants to merge 5 commits into
misskey-dev:developfrom
fruitriin:add-pnpm-permissions
Open

docs(agents): .claude/settings.json に pnpm lint/test/build のパーミッションを追加 #17616
fruitriin wants to merge 5 commits into
misskey-dev:developfrom
fruitriin:add-pnpm-permissions

Conversation

@fruitriin

Copy link
Copy Markdown
Contributor

What

pnpm lint, pnpm test, pnpm build 系のパーミッションを追加します

Why

AGENTS.mdで指定された開発プロセスで使うコマンドがパーミッション不足で失敗するので追加します

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@dosubot dosubot Bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jun 24, 2026
@kakkokari-gtyih kakkokari-gtyih changed the title .claude/settings.json に pnpm lint/test/build のパーミッションを追加 docs(agents): .claude/settings.json に pnpm lint/test/build のパーミッションを追加 Jun 24, 2026

@samunohito samunohito left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

prありがとうございます。
いくつか気になった点があったのでコメントしました

Comment thread .claude/settings.json Outdated
Comment thread .claude/settings.json Outdated
Comment thread .claude/settings.json
"Bash(cp .github/misskey/test.yml .config/test.yml)",
"Bash(ncp .github/misskey/test.yml .config/test.yml)",
"Bash(pnpm --filter backend test*)",
"Bash(pnpm backend-unit-test)",

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"Bash(pnpm backend-unit-test)",

"Bash(pnpm --filter backend test)"があるので不要かと思います(やってることは同じ / LLMが混乱しそうなので統一したほうが良さそう)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

settings.json は システムプロンプトに注入されないので、LLMが選択に悩む原因にはならないと思います
LLMがどちらの選択もとりえるならどちらもないと設定がない方が選ばれたときに止まってしまうほうが不都合かなと。

Comment thread .claude/settings.json Outdated
Comment thread .claude/settings.json Outdated
Comment thread .claude/settings.json Outdated
Comment thread .claude/settings.json Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

Development

Successfully merging this pull request may close these issues.

3 participants