fix: TOTP の認証失敗で 500 Internal Server Error が返ってくる#17594
Open
linze0721 wants to merge 2 commits into
Open
Conversation
dosubot
Bot
added
the
size:S
Member
|
すでにこのIssueを修正するプルリクエストは提出されています. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
変更内容:
Errorを投げて 500 になる問題を修正しました。packages/backend/src/server/api/endpoints/i/2fa/register-key.tspackages/backend/src/server/api/endpoints/i/2fa/key-done.tsINCORRECT_TOTPのApiErrorを追加し、誤ったワンタイムパスワードの場合はクライアントエラーとして返るようにしました。e582826fff fix(backend): return client error for invalid TOTP in passkey setup検証:
pnpm --filter backend typecheckを実行し、成功しました。Closes #17522