Skip to content

remember the URI might be a good idea - #1

Open
jzhang533 wants to merge 1 commit into
mion:masterfrom
jzhang533:rememberURI
Open

remember the URI might be a good idea#1
jzhang533 wants to merge 1 commit into
mion:masterfrom
jzhang533:rememberURI

Conversation

@jzhang533

Copy link
Copy Markdown

remember the URI of the url processing might be a good idea.

@mion

mion commented Sep 4, 2013

Copy link
Copy Markdown
Owner

Cool, thanks @jzhang533 ! But for some reason the test breaks* with:

TypeError: can't convert URI::Generic into String

No big deal though, I think it's just a matter of adding open-uri as a development dependency. Not that I think anyone is using the gem for anything serious after explicitly being told not to 😆, but maybe we could make it backward compatible with something like Harvestman.current_uri (and also leads to a nicer API)? Same thing for the other instace variables like @document. Ideas?
If not I'll just merge it anyway!

[*] Actually it was already 'broken' because it tests for a missing feature I wanted to add.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants