Skip to content

fix: the application uses md5 (crypto in helper.ts #1491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
anupamme wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: the application uses md5 (crypto in helper.ts #1491

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e32c3c7
fix: the application uses md5 (crypto in helper.ts
anupamme Jul 30, 2026
efac9f5
Address review feedback (2 comments)
anupamme Jul 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions src/internal/helper.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -428,9 +428,11 @@ export function sanitizeETag(etag = ''): string {
}

export function toMd5(payload: Binary): string {
// use string from browser and buffer from nodejs
// browser support is tested only against minio server
return crypto.createHash('md5').update(Buffer.from(payload)).digest().toString('base64')
// MD5 is intentionally used here for the Content-MD5 header, which provides
// end-to-end payload integrity verification for S3 operations (RFC 1864).
// It is NOT used for cryptographic security or authentication.
// nosemgrep: use-of-md5
return crypto.createHash('md5').update(Buffer.from(payload)).digest().toString('base64') // nosec
}

export function toSha256(payload: Binary): string {
Expand Down
Loading