Emoji v17 / CLDR 48 - #193
Conversation
|
| ).toFixed(1); | ||
|
|
||
| return fetchAndCache( | ||
| `https://unicode.org/Public/${version}.0.0/ucd/emoji/emoji-data.txt`, |
There was a problem hiding this comment.
Is the change here the patch version being included in the url?
There was a problem hiding this comment.
Yes, there's been a reorganization of the files but this one stayed in the same directory
|
@itsfolf Thanks for starting this. I haven't had the time yet. A few things though:
|
As far as I'm aware there don't seem to be any implementation modifications in tr51, however I am not sure what I'm looking for. As for the po files, I have generated the updated versions with generate:po, filled in the entries for en, merged all other locales with msgmerge, and lastly regenerated the shortcodes. I believe this resulted in the desired state. The official emoji-test.txt is still missing, so that's a blocker on merging for now. |
Yeah this is very weird. Have you found any announcement/post/etc about it not being available? |
Not sure where to look. There seems to be some internal confusion that led to the deletion of the file, as both directories claim to have it. https://www.unicode.org/Public/17.0.0/ucd/emoji/ReadMe.txt https://www.unicode.org/Public/17.0.0/emoji/ReadMe.txt It was previously available under |
|
That's funny, and then it's not available in either, lol. |
|
If you'd like to move forward with a mirror, https://distfiles.alpinelinux.org/distfiles/v3.23/emoji-test-17.0.0.txt is probably trustworthy enough. It was fetched on Oct 20 |
|
@itsfolf Yeah that's fine. Seems like a legit distro. |
Alright, should be ready for final review then. |
|
It's back in |
I believe this is where it's meant to be |
|
Thanks for the contrib! |
I have attempted to begin work on #189
Judging by the v16 PR, the only thing missing should be po files/localization changes, as I did not understand exactly what needs to be done.
I am also currently using a mirror for emoji-test.txt as the official file looks to be temporarily unavailable.