fixed implode arguments & .gitignore for phpstorm

[iz65535]

i've tried to use DummyPrintConnector, but faced with error in implode function

[mike42]

Not shipping this - I think the code is fine - please provide steps to reproduce the error if this is mistaken.

• This is a valid method signature for implode(), see https://www.php.net/manual/en/function.implode.php
• This code has moved to MemoryPrintConnector but still works the same - it is used by test code across all supported PHP versions.

[iz65535]

Hi there,
unfortunately after so many years i don't remember all the details, but i do believe that it would be clear enough, if you just take a look at MemoryPrintConnector ::finalize method:

 public function finalize(): void
    {
        $this -> buffer = null;
    }

this method is public. it puts null to buffer. everybody can call it.
when somebody calls ::getData later, it will throw a warning

php > implode(null);
PHP Warning:  Uncaught TypeError: implode(): If argument #1 ($separator) is of type string, argument #2 ($array) must be of type array, null given in php shell code:1
Stack trace:
#0 php shell code(1): implode()
#1 {main}
  thrown in php shell code on line 1

Another minor detail is, that buffer is declared as an array in class:

/**
     * @var array $buffer
     *  Buffer of accumilated data.
*/
    private $buffer;

which is obviously not true, because practically it can be null under certain circumstances

[mike42]

Oh yep, definitely could still be a bug there. Thanks for the explanation.

That should be enough information for me to confirm/fix. Re-opening this so it doesn't get lost.