-
Notifications
You must be signed in to change notification settings - Fork 107
Basics/fix errors #49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
byronz
wants to merge
2
commits into
miekg:master
Choose a base branch
from
byronz:basics/fix-errors
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -16,7 +16,7 @@ World" in Go. | |
| {callout="//"} | ||
| <{{src/basics/helloworld.go}} | ||
|
|
||
| Lets look at the program line by line. This first line is just required <1>. All | ||
| Let's look at the program line by line. This first line is just required <1>. All | ||
| Go files start with `package <something>`, and `package main` is required for | ||
| a standalone executable. | ||
|
|
||
|
|
@@ -625,7 +625,7 @@ With `a[:]` <4> we create a slice with all the elements in the array. This is a | |
| And with `a[:4]` <5> we create a slice with the elements from index | ||
| 0 to 3, this is short for: `a[0:4]`, and gives us a slices that contains: `1, 2, 3, 4`. | ||
| With `s2[:]` we create a slice from the slice `s2` <6>, note that `s5` still refers to the array `a`. | ||
| Finally, we create a slice with the elements from index 3 to 3 *and* also set the cap to 4 <7>. | ||
| Finally, we create a slice with the elements from index 2 to 3 *and* also set the cap to 3 instead of 5<7>. | ||
|
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. it's about the explanation of s6 := a[2:4:5] |
||
|
|
||
| When working with slices you can overrun the bounds, consider this code. | ||
|
|
||
|
|
@@ -635,7 +635,7 @@ When working with slices you can overrun the bounds, consider this code. | |
| At <1> we create an array with a 100 elements, indexed from 0 to 99. Then at <2> | ||
| we create a slice that has index 0 to 98. We assign 1 to the 99th element <3> of | ||
| the slice. This works as expected. But at <4> we dare to do the impossible, and | ||
| and try to allocate something beyond the length of the slice and we are greeted | ||
|
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. removed the redundant |
||
| try to allocate something beyond the length of the slice and we are greeted | ||
| with a *runtime* error: `Error: "throw: index out of range".` | ||
|
|
||
| If you want to extend a slice, there are a couple of built-in functions that | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
assuming here we mean Let us, not lets as third-person singular