Skip to content

ci: Fix error property name referenced during WinGet uninstall#686

Open
gurry with Copilot wants to merge 3 commits into
mainfrom
copilot/fix-lint-workflow-error
Open

ci: Fix error property name referenced during WinGet uninstall#686
gurry with Copilot wants to merge 3 commits into
mainfrom
copilot/fix-lint-workflow-error

Conversation

Copilot AI commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Fixes this build failure which occurs because we are trying to reference the wrong property InstallerErrorCode instead of the correct one which is UninstallerErrorCode.

Copilot AI requested review from Copilot and removed request for Copilot June 23, 2026 06:13
Copilot AI requested review from Copilot and removed request for Copilot June 23, 2026 06:14
Copilot AI changed the title [WIP] Fix uninstall error property in lint workflow Fix WinGet uninstall error reporting in composite action Jun 23, 2026
Copilot AI requested a review from gurry June 23, 2026 06:15
Copilot finished work on behalf of gurry June 23, 2026 06:15
@gurry gurry changed the title Fix WinGet uninstall error reporting in composite action ci: Fix error property name referenced during WinGet uninstall Jun 23, 2026
@codecov-commenter

codecov-commenter commented Jun 23, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.93%. Comparing base (21ec8f8) to head (98175e2).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #686   +/-   ##
=======================================
  Coverage   79.93%   79.93%           
=======================================
  Files          26       26           
  Lines        5633     5633           
  Branches     5633     5633           
=======================================
  Hits         4503     4503           
  Misses       1002     1002           
  Partials      128      128           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copilot AI review requested due to automatic review settings July 6, 2026 05:48

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a CI failure in the custom GitHub Action that uninstalls WinGet packages by referencing the correct error-code property on the uninstall result object.

Changes:

  • Update the PowerShell error message to use UninstallerErrorCode instead of InstallerErrorCode when uninstall fails.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@gurry gurry marked this pull request as ready for review July 7, 2026 05:02
@gurry gurry requested a review from a team July 7, 2026 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants