feat(cargo-wdk): add `--target-platform` option to the `build` command by svasista-ms · Pull Request #683 · microsoft/windows-drivers-rs

svasista-ms · 2026-06-17T06:31:55Z

Pull request overview

Adds an explicit --target-platform switch to cargo wdk build so users can control which InfVerif validation mode is used when verifying the pacakge's INF.

The option mirrors the Target Platform setting in Visual Studio (Configuration Properties → Driver Settings):

`--target-platform`	InfVerif mode	Validates against
`desktop`	`/h`	WHQL signature requirements
`universal` (default)	`/u`	Universal driver requirements
`windows-driver`	`/w`	Windows Driver requirements

Changes

Introduces the --target-platform CLI argument (kebab-case, case-insensitive) and plumbs it through BuildAction into PackageTask.
Adds a TargetPlatform enum that maps each platform to its InfVerif mode flag.
Updates the tests and README.

⚠️ Behavior change

When --target-platform is not specified, the InfVerif mode now defaults to universal (/u) for all driver models, matching the Visual Studio's defaults.

Previously the mode was derived from the driver model (KMDF/WDM → /w, UMDF → /u). KMDF/WDM drivers built without the new flag will now be validated with /u instead of /w. To retain the previous validation, pass --target-platform windows-driver.

Notes

InfVerif accepts only one mode at a time, so --target-platform selects exactly one.
Support for additional InfVerif switches (e.g. /rulever, /wbuild) via an --infverif-args passthrough is intentionally deferred to a follow-up PR, where it can include validation to prevent specifying multiple modes.

Screenshots

Resolves #490.

…f` mode

Copilot

Pull request overview

Adds an explicit --target-platform switch to cargo wdk build so users can control which InfVerif mode flag is used (/h, /u, /w), addressing the “Desktop drivers need /h” scenario from #490.

Changes:

Introduces --target-platform CLI argument and plumbs it through BuildAction into PackageTask.
Adds a TargetPlatform enum and uses it to select the infverif mode flag (with UMDF default behavior conditional on detected WDK build number).
Updates tests and README documentation to cover the new option and the default derivation logic.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 6 comments.

Show a summary per file

File	Description
crates/cargo-wdk/src/cli.rs	Adds `--target-platform` parsing and maps CLI enum to internal `TargetPlatform`.
crates/cargo-wdk/src/actions/build/mod.rs	Threads `target_platform` through build action params into packaging.
crates/cargo-wdk/src/actions/build/package_task.rs	Implements `TargetPlatform` and uses it to select `InfVerif` mode flag; adds UMDF build-number-based default and tests.
crates/cargo-wdk/src/actions/build/tests.rs	Extends build-action tests to cover overriding `InfVerif` mode via `target_platform`.
crates/cargo-wdk/README.md	Documents the new flag and how default `InfVerif` mode is derived.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

codecov-commenter · 2026-06-17T07:03:45Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.40%. Comparing base (21ec8f8) to head (6e3c59f).

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #683      +/-   ##
==========================================
+ Coverage   79.93%   80.40%   +0.46%     
==========================================
  Files          26       26              
  Lines        5633     5751     +118     
  Branches     5633     5751     +118     
==========================================
+ Hits         4503     4624     +121     
+ Misses       1002      999       -3     
  Partials      128      128

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

…if mode handling + update README

Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

…rget platform options

Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

…ldActionParams and PackageTaskParams

Signed-off-by: Gurinder Singh <gurisingh@microsoft.com>

Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

gurry · 2026-07-01T04:39:57Z

+    /// Validates that the INF meets Universal driver requirements (using
+    /// `InfVerif /u`).


These per-variant args are also AI slop. We should remove them just like in the other struct

gurry · 2026-07-01T06:26:57Z

        }
    }

+    fn assert_default_infverif_mode_flag(


Looks like an almost complete duplicate of assert_target_platform_infverif_mode_flag. Instead of these two methods, we can have a single method which takes, driver_model, target_platform and expected_mode_flag e.g.:

fn assert_infverif_mode_flag( driver_model: DriverConfig, target_platform: TargetPlatform, expected_mode_flag: &'static str, )

gurry · 2026-07-01T07:19:31Z

-    /// Driver signing mode.
+    /// Driver target platform.
+    #[arg(long, value_enum, ignore_case = true)]
+    pub target_platform: Option<TargetPlatformArg>,


I think you can get rid of the Option and declare it simply as TargetPlatformArg if you accept copilot's suggestion above (https://github.com/microsoft/windows-drivers-rs/pull/683/changes#r3503312712)

…idation

…s-drivers-rs into infverif-mode

Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

feat: add --target-platform option to build command to set `InfVeri…

0423f71

…f` mode

Copilot AI review requested due to automatic review settings June 17, 2026 06:31

Copilot started reviewing on behalf of svasista-ms June 17, 2026 06:32 View session

Copilot AI reviewed Jun 17, 2026

View reviewed changes

Merge branch 'main' into infverif-mode

a1c2dbb

svasista-ms changed the title ~~feat: add --target-platform option to build command to set InfVerif mode~~ feat(cargo-wdk): add --target-platform option to build command to set InfVerif mode Jun 17, 2026

svasista-ms marked this pull request as draft June 17, 2026 07:48

feat: update CLI to include target platform options and adjust infver…

76f1a98

…if mode handling + update README

Copilot AI review requested due to automatic review settings June 22, 2026 12:27

Copilot AI reviewed Jun 22, 2026

View reviewed changes

Comment thread crates/cargo-wdk/src/actions/build/package_task.rs Outdated

Comment thread crates/cargo-wdk/src/actions/build/package_task.rs Outdated

Comment thread crates/cargo-wdk/src/cli.rs Outdated

Copilot started reviewing on behalf of svasista-ms June 22, 2026 12:34 View session

refactor: reorder build command options + clarify doc comments for ta…

193cd94

…rget platform options

svasista-ms requested a review from Copilot June 24, 2026 04:56

svasista-ms marked this pull request as ready for review June 24, 2026 04:57

Copilot started reviewing on behalf of svasista-ms June 24, 2026 04:57 View session

Copilot AI reviewed Jun 24, 2026

View reviewed changes

Comment thread crates/cargo-wdk/src/cli.rs Outdated

Comment thread crates/cargo-wdk/src/actions/build/package_task.rs Outdated

Comment thread crates/cargo-wdk/src/actions/build/tests.rs Outdated

gurry reviewed Jun 24, 2026

View reviewed changes

Comment thread crates/cargo-wdk/src/actions/build/package_task.rs Outdated

Comment thread crates/cargo-wdk/src/actions/build/package_task.rs Outdated

Comment thread crates/cargo-wdk/src/actions/build/mod.rs Outdated

refactor: change target_platform from Option to required field in Bui…

455e48f

…ldActionParams and PackageTaskParams

krishnakumar4a4 reviewed Jun 29, 2026

View reviewed changes

Comment thread crates/cargo-wdk/src/cli.rs Outdated

Merge branch 'main' into infverif-mode

494c9d7

Signed-off-by: Gurinder Singh <gurisingh@microsoft.com>

Copilot AI review requested due to automatic review settings July 1, 2026 04:34

Copilot started reviewing on behalf of gurry July 1, 2026 04:34 View session

Copilot AI reviewed Jul 1, 2026

View reviewed changes

Comment thread crates/cargo-wdk/src/actions/build/package_task.rs Outdated

Comment thread crates/cargo-wdk/src/cli.rs Outdated

Comment thread crates/cargo-wdk/README.md

gurry reviewed Jul 1, 2026

View reviewed changes

svasista-ms changed the title ~~feat(cargo-wdk): add --target-platform option to build command to set InfVerif mode~~ feat(cargo-wdk): add --target-platform option to the build command Jul 1, 2026

svasista-ms added 3 commits July 1, 2026 16:15

docs: update README to specify default target platform for driver val…

724504b

…idation

Merge branch 'infverif-mode' of https://github.com/svasista-ms/window…

e25924c

…s-drivers-rs into infverif-mode

refactor: target platform conversion in run function

546d35e

svasista-ms added 2 commits July 1, 2026 17:01

fix: include TargetPlatformArg in CLI tests

dc4933b

fix: correct comment typo regarding InfVerif CLI /samples flag

6e3c59f

Copilot AI review requested due to automatic review settings July 1, 2026 11:56

Copilot started reviewing on behalf of svasista-ms July 1, 2026 11:57 View session

Copilot AI reviewed Jul 1, 2026

View reviewed changes

Comment thread crates/cargo-wdk/src/actions/build/package_task.rs

Comment thread crates/cargo-wdk/src/actions/build/package_task.rs

Comment thread crates/cargo-wdk/src/actions/build/package_task.rs

		/// Validates that the INF meets Universal driver requirements (using
		/// `InfVerif /u`).

Uh oh!

Conversation

svasista-ms commented Jun 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull request overview

Changes

⚠️ Behavior change

Notes

Screenshots

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codecov-commenter commented Jun 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gurry Jul 1, 2026

Choose a reason for hiding this comment

Uh oh!

svasista-ms Jul 1, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

gurry Jul 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

svasista-ms Jul 1, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

gurry Jul 1, 2026

Choose a reason for hiding this comment

Uh oh!

svasista-ms Jul 1, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

svasista-ms commented Jun 17, 2026 •

edited

Loading

codecov-commenter commented Jun 17, 2026 •

edited

Loading

gurry Jul 1, 2026 •

edited

Loading