Skip to content

fix(winapp-pr): paginate the artifacts query so a busy run's package is findable #705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nmetulev merged 2 commits into from
Jul 31, 2026
+7 −2
Merged

fix(winapp-pr): paginate the artifacts query so a busy run's package is findable #705

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
21841cc
fix(winapp-pr): paginate the artifacts query so a busy run's package …
nmetulev Jul 31, 2026
3612ce8
Potential fix for pull request finding
nmetulev Jul 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions scripts/winapp-pr.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -616,15 +616,20 @@ function Get-MsixArtifact {
param([string]$RepoName, [object[]]$Runs, [switch]$Quiet)

foreach ($run in $Runs) {
# --paginate is load-bearing: the artifacts endpoint returns 30 per page, and a run that
# uploads more than that pushes msix-packages onto page 2, where an unpaginated query
# cannot see it. The symptom is indistinguishable from a run that genuinely never built a
# package -- the walk-back to an older run looks like it is working, and silently hands
# back a stale build. Do not remove this without checking .total_count on a busy run.
$artifacts = Invoke-Gh @('api', "repos/$RepoName/actions/runs/$($run.id)/artifacts",
'--jq', '.artifacts')
'--paginate', '--jq', '.artifacts')
Comment on lines 624 to +625
$msix = $artifacts | Where-Object { $_.name -eq $ArtifactName -and -not $_.expired } |
Select-Object -First 1
if ($msix) {
return [pscustomobject]@{ Run = $run; Artifact = $msix }
}
if (-not $Quiet) {
Write-Detail "Run $($run.id) has no usable $ArtifactName artifact, trying older run..."
Write-Detail "Run $($run.id) has no usable $ArtifactName artifact among its $(($artifacts | Measure-Object).Count), trying older run..."
}
}
return $null
Expand Down
Loading