Align Cloud Agent closer to Mission Control's existing behavior#313243
Open
A-Georgiou wants to merge 4 commits into
Open
Align Cloud Agent closer to Mission Control's existing behavior#313243A-Georgiou wants to merge 4 commits into
A-Georgiou wants to merge 4 commits into
Conversation
Port of microsoft/vscode-copilot-chat#5078 (by @Oregand) to vscode core. VS Code's Cloud Agent flow was still doing pre-PR work that Mission Control / CCA PR Decoupling no longer needs: - Drop the delegate/commit/push modal. New-request path goes straight to delegate(). Permissive GitHub auth kicks in via the standard non-modal createIfNone sign-in prompt. - Send the raw user prompt. Stop calling IChatDelegationSummaryService.summarize on the delegation path. problem_statement is now the user prompt + resolved references only. - Match MC's minimal pull_request payload. Drop body_placeholder and body_suffix — keep title, base_ref, and optional head_ref. - Drop the pre-delegation git preflight. Removed detectedUncommittedChanges, checkBaseBranchPresentOnRemote, buildConfirmation, and handleConfirmationData. - Delete dead code. CopilotCloudGitOperationsManager is now unreachable — removed the whole file. Regressions fixed (from original PR review): 1. Current remote-tracking branch preserved as base_ref when available 2. Auth cancellation gate moved inside delegate() for all callers 3. Uncommitted-changes warning checks both workingTree and indexChanges 4. Base-branch fallback now shows stream.progress notice Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Author
|
@microsoft-github-policy-service agree |
Contributor
There was a problem hiding this comment.
Pull request overview
Ports Mission Control’s “PR-decouple” cloud agent delegation behavior into VS Code core by simplifying the Cloud Agent flow (no modal/preflight/summarization) and aligning the job payload shape.
Changes:
- Remove the delegate/commit/push confirmation modal + git preflight; new requests delegate immediately.
- Stop summarizing chat history for delegation; send the raw user prompt plus resolved references as the problem context.
- Align the remote-agent job
pull_requestpayload to a minimal shape and delete the now-unreachable git operations manager.
Show a summary per file
| File | Description |
|---|---|
| extensions/copilot/src/extension/chatSessions/vscode/copilotCodingAgentUtils.ts | Removes PR body placeholder/suffix helpers no longer used in the decoupled flow. |
| extensions/copilot/src/extension/chatSessions/vscode-node/copilotCloudSessionsProvider.ts | Implements direct delegation, permissive auth gating inside delegate(), base-ref selection tweaks, minimal PR payload. |
| extensions/copilot/src/extension/chatSessions/vscode-node/copilotCloudGitOperationsManager.ts | Deletes unreachable preflight/commit/push helper (entire file removed). |
| extensions/copilot/src/extension/chatSessions/vscode-node/copilotCLIChatSessionsContribution.ts | Updates uncommitted-changes detection to include working tree changes. |
| extensions/copilot/src/extension/chatSessions/vscode-node/copilotCLIChatSessions.ts | Same uncommitted-changes detection update for the other CLI participant implementation. |
Copilot's findings
- Files reviewed: 5/5 changed files
- Comments generated: 3
- Use optional chaining with nullish coalescing on hasChanges checks across all three files to guard against partial changes objects in mocks/stubs (indexChanges/workingTree may be undefined). - Gate the branch-not-on-remote progress message behind selectedMatchesActive so it only fires when the active repo matches the selected repo, avoiding misleading messages in multi-root workspaces. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
A-Georgiou
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port of microsoft/vscode-copilot-chat#5078 (by @Oregand) to vscode core.
VS Code's Cloud Agent flow was still doing pre-PR work that Mission Control / CCA PR Decoupling no longer needs:
createIfNonesign-in prompt.IChatDelegationSummaryService.summarizeon the delegation path. problem_statement is now the user prompt + resolved references only.body_placeholderandbody_suffix, keeptitle,base_ref, and optionalhead_ref.detectedUncommittedChanges,checkBaseBranchPresentOnRemote,buildConfirmation, andhandleConfirmationData.CopilotCloudGitOperationsManageris now unreachable - removed the whole file.