This repository was archived by the owner on May 20, 2026. It is now read-only.
Security: Overly permissive GitHub remote detection via prefix match - #5055
Open
tuanaiseo wants to merge 1 commit into
Open
Conversation
…a pref
GitHub remotes are identified using `uri.authority.startsWith('github')`. This can be spoofed by authorities like `github.evil.example`, potentially causing untrusted remotes to be treated as GitHub remotes if this check gates trust, auth behavior, or feature enablement.
Affected files: utils.ts
Signed-off-by: tuanaiseo <221258316+tuanaiseo@users.noreply.github.com>
Member
|
Thanks for the contribution! This repository has been archived because the project has moved into the main VS Code repository. Could you please reopen/recreate this PR against: We’ll continue reviewing contributions there. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
GitHub remotes are identified using
uri.authority.startsWith('github'). This can be spoofed by authorities likegithub.evil.example, potentially causing untrusted remotes to be treated as GitHub remotes if this check gates trust, auth behavior, or feature enablement.Severity:
mediumFile:
src/platform/remoteRepositories/common/utils.tsSolution
Replace prefix matching with strict authority validation (exact host match or vetted suffix list, e.g.,
github.com,*.github.devas required). Normalize case and parse host components before comparison.Changes
src/platform/remoteRepositories/common/utils.ts(modified)Testing